-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop a design pattern for Alt input of toolboxes/creator pattern #166
Comments
I created a prototype that is a bit rough, but could be used in the design process. See it implemented for the stopwatch node on the first screen of https://phet-dev.colorado.edu/html/waves-intro/1.2.0-altInputToolbox.1/phet/waves-intro_all_phet.html Current implementation:
Still to do/some random questions I had:
|
Meeting 3/6/24:
|
The design pattern for navigating and grabbing tools from a toolbox:
|
What's missing in GO and GO:B is any visual hint that one needs to grab a tool with Space. |
I think for the toolbox/creator pattern https://phetsims.github.io/scenery/examples/creator-pattern.html, the two-step Grab and Drag designed for GO and GO:B is really good and works well I do not think a second two-step grab interaction once the tool is activated and in the Play Area is necessary. Important things to ensure/consider:
Workarounds and other considerations:
Description Design Consideration for the Future
To Do's for Toolbox/Creator pattern (future work)
|
@zepumph, I think I documented the design pattern for the toolbox/creator pattern, and I included design considerations and to-dos. I am not sure this all constitutes what we need. @marlitas 's comment in #166 (comment) seems to be about "already-in-the-Play-Area draggable sim objects" which seem different than draggable tools activated from a toolbox or by a checkbox. Should I also include a design pattern that documents the current alt input approach (i.e., no two-step drag) for readily available draggable sim objects - sim objects that are not activated from a toolbox or by a checkbox? |
Signed-off-by: Michael Kauzmann <[email protected]>
Signed-off-by: Michael Kauzmann <[email protected]>
Signed-off-by: Michael Kauzmann <[email protected]>
…h#166 Signed-off-by: Michael Kauzmann <[email protected]>
Signed-off-by: Michael Kauzmann <[email protected]>
…h#166 Signed-off-by: Michael Kauzmann <[email protected]>
Signed-off-by: Michael Kauzmann <[email protected]>
I think I committed my 2 files Toolbox.md and an image. |
Signed-off-by: Michael Kauzmann <[email protected]>
Excellent! |
ToolboxPattern is a go. Let's look at binder tomorrow, and I'll update the alt-input dev docs. |
Signed-off-by: Michael Kauzmann <[email protected]>
Signed-off-by: Michael Kauzmann <[email protected]>
Signed-off-by: Michael Kauzmann <[email protected]>
Signed-off-by: Michael Kauzmann <[email protected]>
Signed-off-by: Michael Kauzmann <[email protected]>
I don't see it in Binder yet. |
Me neither! I'm going to check in on how the build went, and kick off something locally to see if it ran into a problem. |
Looks like binder hasn't been getting updated since january because of an unrelated bug. It will be running from here (fix in phetsims/chipper#1376) |
Alright. Binder is live with the toolbox pattern: https://phetsims.github.io/binder/#sun-ToolboxPattern. Anything else here @terracoda? |
There are some typos, I need to fix in the MD file for this design patter. |
I fixed up the text. I will share this documentation with designers at our next design meeting. Closing issue. |
This issue has been in many people's minds for quite some time, but most recently this has come about in phetsims/geometric-optics#258.
Please make sure to go look at that GO issue, as there was quite a bit of discussion about the general design over there.
This is likely scheduled for work during Q1 2022. We will proceed from there. It is currently blocking the publication Geometric Optics, though that could potentially change.
I was curious about how challenging it may be to implement a basic usage of this, in which the toolbox icons are buttons, and when clicked, they focus the draggable Node. In waves-intro, I was able to add an example of this quite easily! It took ~30 minutes to get something that feels solid enough to inform a design meeting for it. I plan to commit these changes to a branch, and publish a one-off version of waves-intro for use in the design process.
The text was updated successfully, but these errors were encountered: