Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Interactive Descriptions" to "Interactive Description" across the project #157

Closed
zepumph opened this issue Apr 15, 2020 · 9 comments

Comments

@zepumph
Copy link
Member

zepumph commented Apr 15, 2020

I hear @terracoda over in #145 (comment). We should make sure to fix this across the project

Currently there are 23 usages of interactiveDescriptions, and 19 usages of "interactive descriptions" (case insensitive).

@jessegreenberg whoever get's this this first.

@zepumph zepumph changed the title Rename "Interactive Descriptions" to "InteractiveDescription" across the project Rename "Interactive Descriptions" to "Interactive Description" across the project Apr 15, 2020
zepumph added a commit to phetsims/circuit-construction-kit-ac that referenced this issue Feb 2, 2021
zepumph added a commit to phetsims/circuit-construction-kit-dc-virtual-lab that referenced this issue Feb 2, 2021
zepumph added a commit to phetsims/circuit-construction-kit-dc that referenced this issue Feb 2, 2021
zepumph added a commit to phetsims/coulombs-law that referenced this issue Feb 2, 2021
zepumph added a commit to phetsims/faradays-law that referenced this issue Feb 2, 2021
zepumph added a commit to phetsims/gravity-force-lab-basics that referenced this issue Feb 2, 2021
zepumph added a commit to phetsims/gravity-force-lab that referenced this issue Feb 2, 2021
zepumph added a commit to phetsims/greenhouse-effect that referenced this issue Feb 2, 2021
zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Feb 2, 2021
zepumph added a commit to phetsims/john-travoltage that referenced this issue Feb 2, 2021
zepumph added a commit to phetsims/molecules-and-light that referenced this issue Feb 2, 2021
zepumph added a commit to phetsims/ratio-and-proportion that referenced this issue Feb 2, 2021
zepumph added a commit to phetsims/resistance-in-a-wire that referenced this issue Feb 2, 2021
zepumph added a commit to phetsims/scenery-phet that referenced this issue Feb 2, 2021
zepumph added a commit to phetsims/balloons-and-static-electricity that referenced this issue Feb 2, 2021
@jessegreenberg
Copy link
Contributor

Dependencies have been updated for release branches in phetsims/phetmarks#48. The only exception a phet-io specific release branch of molarity which will be taken care of separately in that issue.

I verified that phetmarks is launchable from atomic-interactions 1.2 SHAs again. @jbphet reassigning to you to verify if you wish, otherwise I think this can be closed.

@jbphet
Copy link
Contributor

jbphet commented Mar 9, 2021

I tested this by checkout out the 1.2 branch of atomic-interactions and testing phetmarks, and it worked fine. Thanks for the fix @jessegreenberg and @zepumph. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants