Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1099-Gitlab-integration-should-manage-non-default-port #1101

Conversation

jecisc
Copy link
Contributor

@jecisc jecisc commented Dec 4, 2018

Add possibility to clone project from self hosted gitlab with non default ssh port via the Metacello integration.

Fixes #1099

/!\ This needs pharo-project/pharo#2041 before it can work

…ault ssh port via the Metacello integration.

Fixes pharo-vcs#1099

/!\ This needs pharo-project/pharo#2041 before it can work
@jecisc
Copy link
Contributor Author

jecisc commented Dec 14, 2018

Can someone relaunch this build? Dependency PR was integrated in Pharo

@guillep
Copy link
Member

guillep commented Dec 18, 2018

I've relaunched the builds

@guillep
Copy link
Member

guillep commented Dec 18, 2018

Well, this breaks pharo6 compatibility

MessageNotUnderstood: MCGitlabRepository>>sshPort
MCGitlabRepository(Object)>>doesNotUnderstand: #sshPort
MCGitlabRepository>>scpUrl
MCGitlabRepositoryIcebergExtensionsTest>>testScpUrl ...scpUrl
MCGitlabRepositoryIcebergExtensionsTest(TestCase)>>performTest

I know that we shouldn't keep it forever, but until Pharo7 is not out...

@jecisc
Copy link
Contributor Author

jecisc commented Dec 18, 2018

I’ll try to fix the PR at the end of the week probably.

@gcotelli
Copy link
Contributor

@jecisc try to do something similar to what I do with the original support. There's a package for Pharo 6 compatibility, you can add here the necessary extensions.

@jecisc
Copy link
Contributor Author

jecisc commented Dec 19, 2018

Updated

@guillep guillep merged commit 0e98cbc into pharo-vcs:dev-1.0 Dec 26, 2018
@guillep guillep added this to the v1.4.2 milestone Dec 26, 2018
@jecisc jecisc deleted the 1099-Gitlab-integration-should-manage-non-default-port branch November 21, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants