Merge pull request #1101 from jecisc/1099-Gitlab-integration-should-m…

…anage-non-default-port

1099-Gitlab-integration-should-manage-non-default-port

Iceberg-Pharo6.package/MCGitlabRepository.extension/instance/scpUrl.st

@@ -0,0 +1,6 @@
+*Iceberg-Pharo6
+sshPort
+	"In pharo 6 we do not have the code to be able to load gitlab with non default ssh port projects. So we return nil so that #scpUrl does not break."
+
+	^ nil
+

Iceberg-Tests.package/MCGitlabRepositoryIcebergExtensionsTest.class/instance/testScpUrlForSelfHostedGitlabWithNonDefaultSSHPort.st

@@ -0,0 +1,7 @@
+running
+testScpUrlForSelfHostedGitlabWithNonDefaultSSHPort
+	| repository |
+	SystemVersion current major <= 6 ifTrue: [ self skip ].
+
+	repository := MCGitlabRepository location: 'gitlab://git.pharo.org:1234:pharo-project/pharo'.
+	self assert: repository scpUrl equals: 'ssh://[email protected]:1234/pharo-project/pharo.git'

Iceberg.package/MCGitlabRepository.extension/instance/scpUrl.st

@@ -1,3 +1,7 @@
 *Iceberg
 scpUrl
-	^ 'git@<1s>:<2s>.git' expandMacrosWith: self hostname with: projectPath
+	"If the sshPort is not nil it means that we have a non default ssh port. Thus we need to add `ssh://` and th port number to the scheme"
+
+	^ self sshPort
+		ifNil: [ 'git@<1s>:<2s>.git' expandMacrosWith: self hostname with: projectPath ]
+		ifNotNil: [ :port | 'ssh://git@<1s>:<2s>/<3s>.git' expandMacrosWith: self hostname with: port with: projectPath ]