Bug fix: Context menu item ‘Revert to selected version’ in recent versions of a method does not revert

src/BaselineOfNewTools/BaselineOfNewTools.class.st

@@ -26,6 +26,7 @@ BaselineOfNewTools >> baseline: spec [
 			package: 'NewTools-Gtk';
 			"Basic tools (inherited from Spec)"
 			package: 'NewTools-MethodBrowsers' with: [ spec requires: #( 'NewTools-SpTextPresenterDecorators' ) ];
+			package: 'NewTools-MethodBrowsers-Tests' with: [ spec requires: #( 'NewTools-MethodBrowsers' ) ];
 			package: 'NewTools-KeymapBrowser';
 			"inspector"
 			package: 'NewTools-Inspector' with: [ spec requires: #( 'NewTools-Inspector-Extensions' ) ];

src/NewTools-MethodBrowsers-Tests/StVersionBrowserPresenterTest.class.st

@@ -0,0 +1,41 @@
+Class {
+	#name : 'StVersionBrowserPresenterTest',
+	#superclass : 'TestCase',
+	#instVars : [
+		'class',
+		'factory'
+	],
+	#category : 'NewTools-MethodBrowsers-Tests',
+	#package : 'NewTools-MethodBrowsers-Tests'
+}
+
+{ #category : 'running' }
+StVersionBrowserPresenterTest >> setUp [
+	super setUp.
+	factory := ClassFactoryForTestCase new.
+	class := factory newClass
+
+]
+
+{ #category : 'running' }
+StVersionBrowserPresenterTest >> tearDown [
+	factory cleanUp.
+	super tearDown
+]
+
+{ #category : 'running' }
+StVersionBrowserPresenterTest >> testRevertOldMethod [ 
+	| browser |
+	class compile: 'm
+	^1'.
+	self assert: class new m equals: 1.
+	class compile: 'm
+	^2'.
+	self assert: class new m equals: 2.
+	browser := StVersionBrowserPresenter on: class >> #m.
+	browser selectIndex: browser changeList size.
+	browser doRevert.
+	self assert: class new m equals: 1.
+
+
+]

src/NewTools-MethodBrowsers-Tests/package.st

@@ -0,0 +1 @@
+Package { #name : 'NewTools-MethodBrowsers-Tests' }

src/NewTools-MethodBrowsers/StVersionBrowserPresenter.class.st

@@ -197,7 +197,7 @@ StVersionBrowserPresenter >> doCompareToOtherVersion [
 
 { #category : 'actions' }
 StVersionBrowserPresenter >> doRevert [
-
+	self revert: self selectedMessage
 ]
 
 { #category : 'initialization' }
@@ -296,7 +296,7 @@ StVersionBrowserPresenter >> newMessageList [
 StVersionBrowserPresenter >> newMessageToolbar [
 
 	^ (self instantiate: StMethodHistoryToolbarPresenter on: rgMethod)
-		whenRevertDo: [ self revert: self selectedMessage ];
+		whenRevertDo: [ self doRevert ];
 		yourself
 ]
 
@@ -345,6 +345,12 @@ StVersionBrowserPresenter >> revert: aChangeRecord [
 		selectIndex: 1
 ]
 
+{ #category : 'test support' }
+StVersionBrowserPresenter >> selectIndex: index [
+
+	messageList selectIndex: index
+]
+
 { #category : 'private' }
 StVersionBrowserPresenter >> selectItem: item [