Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: Context menu item ‘Revert to selected version’ in recent versions of a method does not revert #710

Merged
merged 5 commits into from
Feb 24, 2024
Merged

Bug fix: Context menu item ‘Revert to selected version’ in recent versions of a method does not revert #710

merged 5 commits into from
Feb 24, 2024

Conversation

bouraqadi
Copy link
Contributor

Fix for issue 16045 raised in Pharo.
In method version browser, revert context menu should actually revert method version.

@bouraqadi bouraqadi mentioned this pull request Feb 23, 2024
Closed
@bouraqadi
Copy link
Contributor Author

bouraqadi commented Feb 23, 2024 •
edited
Loading

There a build test failure. But, it is not related to this fix:

SystemDependenciesTest
 ✗ #testExternalIDEDependencies (66ms)
TestFailure: Given Collections do not match!
	additions : #('Microdown' 'Microdown-RichTextComposer')
	missing: #()

@Ducasse
Copy link
Contributor

Ducasse commented Feb 24, 2024

Thanks! This is cool that you fixed it!

@Ducasse Ducasse merged commit 7e90acb into pharo-spec:Pharo12 Feb 24, 2024
1 of 2 checks passed
@MarcusDenker MarcusDenker changed the title Bug fix for Pharo issue 16045 Bug fix: Context menu item ‘Revert to selected version’ in recent versions of a method does not revert Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demarey demarey demarey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bouraqadi @Ducasse @demarey