616 print image process list in nice formatted way

[Bajger]

fixes #616

[Bajger]

Will add unit tests in additional commit

[Bajger]

@demarey Hi Christophe! Finally had chance to provide needed changes. Please take a look!

[Bajger]

Found the issue in parsing line with process information. I didn't test it with pharo processes that run with --headless parameter (or other vm or image params). Therefore parsing is shifted.

[Bajger]

@demarey Please take a look. Process list identification should be robust enough now, I hope I found all cornercases for pgrep. Should be working both on Linux and MacOS (tested).

• I will squash commit and merge to feature/cmd-line
• then cherrypick to dev branch and move fiunctionality to PhLProcessListCliCommand (via new PR)?

Note: There was a funny problem which I could not identify, since pgrep returns exitCode 1 in case of no process match. This resulted in exception in OS Shell command execution in Pharo - since exitSuccess is tested there. Lessons learned (read man pages) :-)

[demarey]

I did a local merge with dev branch and running tests.
I see a problem with date convertion:

OS process command: '/bin/zsh -c ps -o lstart= -p "1974" | xargs -I{} date -jf "%a %b %e %T %Y" "{}" '+%Y-%m-%d %H:%M:%S''  exited with: normal termination with status 1.
Stderr contents: "Failed conversion of ``Lun 29 jan 12:34:40 2024'' using format ``%a %b %e %T %Y''
date: illegal time format
usage: date [-jnRu] [-I[date|hours|minutes|seconds]] [-f input_fmt]
            [-r filename|seconds] [-v[+|-]val[y|m|w|d|H|M|S]]
            [[[[mm]dd]HH]MM[[cc]yy][.SS] | new_date] [+output_fmt]
".

[Bajger]

Lun 29 jan 12:34:40 2024
This is date in French localization? I will test with it.

[demarey]

Lun 29 jan 12:34:40 2024
This is date in French localization? I will test with it.

Yes. And maybe there could be other issues with otherlocalizations. Maybe there is a way to use an ISO format ?

[Bajger]

@demarey: Please try now.

[demarey]

@demarey: Please try now.

Not yet

OS process command: '/bin/zsh -c LANG=C ps -o lstart= -p "1974" | xargs -I{} date -jf "%a %b %e %T %Y" "{}" '+%Y-%m-%d %H:%M:%S''  exited with: normal termination with status 1.
Stderr contents: "Failed conversion of ``Mon Jan 29 12:34:40 2024'' using format ``%a %b %e %T %Y''
date: illegal time format
usage: date [-jnRu] [-I[date|hours|minutes|seconds]] [-f input_fmt]
            [-r filename|seconds] [-v[+|-]val[y|m|w|d|H|M|S]]
            [[[[mm]dd]HH]MM[[cc]yy][.SS] | new_date] [+output_fmt]
".

[Bajger]

This is strange, if I evaluate on my MacOS:

dbajger@Davids-MacBook-Pro P11-launcher-dev % LANG=C ps -o lstart= -p 50442 | xargs -I{} date -jf "%a %b %e %T %Y" "{}" '+%Y-%m-%d %H:%M:%S' 
2024-01-31 09:07:55

So on my computer works. I don't know. Date formatting to ISO is really clumsy.

[demarey]

after investigation the command that works on my mac is:
date -j -u -f "%a %d %b %H:%M:%S %Y" '+%Y-%m-%d %H:%M:%S' "Lun 29 jan 12:26:05 2024"

[Bajger]

@demarey Tested on my Mac with adopted time attributes (571fa76) . Please let me know!

[demarey]

@Bajger Did you see my PR on this topic on your repository?

[Bajger]

@Bajger Did you see my PR on this topic on your repository?

Hi @demarey ! Sorry I didn't recognize that. To resolve conflicts, I need to checkout my branch or https://github.com/pharo-project/pharo-launcher/tree/enh/PR616 ?

GitHub

GitHub - pharo-project/pharo-launcher at enh/PR616

Lets you manage your pharo images and download new ones - GitHub - pharo-project/pharo-launcher at enh/PR616

[demarey]

Hi @demarey ! Sorry I didn't recognize that. To resolve conflicts, I need to checkout my branch or https://github.com/pharo-project/pharo-launcher/tree/enh/PR616 ?

I just diid the merge. The PR is up to date

GitHub

GitHub - pharo-project/pharo-launcher at enh/PR616

Lets you manage your pharo images and download new ones - GitHub - pharo-project/pharo-launcher at enh/PR616