Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for including the builds after build 1258 #670

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

hernanmd
Copy link
Member

This PR address the issue #667.

It updates the regular expression filter pattern in sources.list, to match lines beginning with href, then followed by "Pharo-12" and optionally followed by a dot and minor version numbers.

Hernán Morales Durand and others added 2 commits January 31, 2024 17:44
@demarey
Copy link
Contributor

demarey commented Feb 1, 2024

I updated the regex as this one will match more expressions than wanted.
I also added a test for it.
All this is available through a PR on your branch: hernanmd#1

Copy link
Member Author

@hernanmd hernanmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This updates makes the regular expression to require at least one digit after the dot. It is correct.

sources.list Outdated Show resolved Hide resolved
Co-authored-by: demarey <[email protected]>
@demarey demarey merged commit d4284cc into pharo-project:dev Feb 1, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants