Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using "Show in folder" gives DNU #568

Closed
astares opened this issue Jun 8, 2022 · 3 comments · Fixed by #569
Closed

Using "Show in folder" gives DNU #568

astares opened this issue Jun 8, 2022 · 3 comments · Fixed by #569
Labels

Comments

@astares
Copy link
Member

astares commented Jun 8, 2022

When you use "Show in folder" from the context menu in the images list on Windows 10 it gives a DNU:

image

@astares astares added the Bug label Jun 8, 2022
@astares
Copy link
Member Author

astares commented Jun 8, 2022

The problem is that these methods are implemented on Win32Platform and are not available to class Win64Platform

image

I guess we need to move them to superclass WinPlatform or use a call to "ShellExecuteW" for Win64.

This is already a problem that need to be fixed in underlying Pharo platform - not really a problem of Launcher itself.

@astares
Copy link
Member Author

astares commented Jun 8, 2022

Quick and dirty workaround: moving the two method to WinPlatform solved the issue.

@astares
Copy link
Member Author

astares commented Jun 8, 2022

It had been solved already here: dbca063

BUT:

The launcher should better use the method #openInOSFileBrowser on a file refernence in newer Pharo versions.

Example:

FileSystem workingDirectory openInOSFileBrowser

astares added a commit to astares/pharo-launcher that referenced this issue Jun 8, 2022
demarey pushed a commit that referenced this issue Jun 9, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…rowser in more recent versions of Pharo (#569)

Fix #568
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant