Remove unnecessary complex code and test to now simply #openInOSFileB…

…rowser in more recent versions of Pharo Fix pharo-project#568
astares · Jun 8, 2022 · 3495b35 · 3495b35
1 parent dfadffa
commit 3495b35
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 103 deletions.
diff --git a/src/PharoLauncher-Core/PhLFileBrowser.class.st b/src/PharoLauncher-Core/PhLFileBrowser.class.st
diff --git a/src/PharoLauncher-Core/PhLImage.class.st b/src/PharoLauncher-Core/PhLImage.class.st
@@ -479,7 +479,7 @@ PhLImage >> shouldRunInitializationScript: aBoolean [
 
 { #category : #printing }
 PhLImage >> showNativeFolder [
-	PhLFileBrowser openOn: file
+	file asFileReference openInOSFileBrowser 
 ]
 
 { #category : #'private ui' }

diff --git a/src/PharoLauncher-Core/PhLVirtualMachine.class.st b/src/PharoLauncher-Core/PhLVirtualMachine.class.st
@@ -356,7 +356,7 @@ PhLVirtualMachine >> removeFromSystem [
 
 { #category : #actions }
 PhLVirtualMachine >> showInFolder [
-	PhLFileBrowser openOn: self vmStore / self id
+	(self vmStore / self id) asFileReference openInOSFileBrowser 
 ]
 
 { #category : #'ston persistence' }

diff --git a/src/PharoLauncher-Core/WinPlatform.extension.st b/src/PharoLauncher-Core/WinPlatform.extension.st
@@ -9,30 +9,6 @@ WinPlatform >> hostArchitecture [
 	^ processorArch 
 ]
 
-{ #category : #'*PharoLauncher-Core' }
-WinPlatform >> privShellExecute: lpOperation file: lpFile parameters: lpParameters directory: lpDirectory show: nShowCmd [
-
-	^self ffiCall: #( 
-			FFIConstantHandle ShellExecuteA(
-     				0,
-     				char* lpOperation,
-         			char* lpFile,
-     				char* lpParameters,
-     				char* lpDirectory,
-        			int nShowCmd)) module: #shell32
-
-
-]
-
-{ #category : #'*PharoLauncher-Core' }
-WinPlatform >> privShellExplore: folder [
-	"
-	self privShellExplore: 'c:\'
-	"
-
-	^self privShellExecute: 'explore' file: folder parameters: '' directory: '' show: 5 "SW_SHOW"
-]
-
 { #category : #'*PharoLauncher-Core' }
 WinPlatform >> uname [
 	^ PhLVmProvider osWindows

diff --git a/src/PharoLauncher-Tests-Core/PhLFileBrowserTest.class.st b/src/PharoLauncher-Tests-Core/PhLFileBrowserTest.class.st