Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade {fontawesome} #400

Merged
merged 5 commits into from
Feb 7, 2023
Merged

Upgrade {fontawesome} #400

merged 5 commits into from
Feb 7, 2023

Conversation

AARON-CLARK
Copy link
Collaborator

@AARON-CLARK AARON-CLARK commented Feb 7, 2023

Fixes part of #399

This PR:

  • updates renv lock file which is pointing at fa v2.2.1 (really old) to v0.5.0
  • removes custom GHA installation of fa v0.3.0 in favor of the recently released v0.5.0
  • Removes login note & console messages regarding installing v0.3.0 and instead re-focuses on installing a recent version when it detects the problematic v0.4.0 is installed
  • adds fa to Suggests field
  • Oh, it also updates our R version to v4.2.2

Note, once this if fixed, we can push through other PRs

One problem I see with v0.5.0 is that it produces a new warning in the console when a report is downloaded (which I'm not sure we have any control over):

image

Thoughts? We could go back to v0.3.0 I suppose to avoid it?

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #400 (ae77b00) into dev (fb6b17a) will decrease coverage by 0.11%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##              dev     #400      +/-   ##
==========================================
- Coverage   86.29%   86.18%   -0.11%     
==========================================
  Files          22       22              
  Lines        2152     2150       -2     
==========================================
- Hits         1857     1853       -4     
- Misses        295      297       +2     
Impacted Files Coverage Δ
R/utils_startup.R 64.44% <0.00%> (ø)
R/mod_downloadHandler.R 63.20% <16.66%> (-2.16%) ⬇️
R/run_app.R 72.72% <50.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AARON-CLARK
Copy link
Collaborator Author

Quick update, it appears the xfun:isFalse() issue stems from this and this. Reverting back a release fixes the issue (for now).

Copy link
Collaborator

@borgmaan borgmaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@borgmaan borgmaan merged commit 73bf6e6 into dev Feb 7, 2023
@borgmaan borgmaan deleted the ac-399-upgrade-fa branch February 7, 2023 21:03
@aclark02-arcus aclark02-arcus mentioned this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants