Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renv/GHA Cleanup #399

Closed
borgmaan opened this issue Feb 7, 2023 · 2 comments
Closed

renv/GHA Cleanup #399

borgmaan opened this issue Feb 7, 2023 · 2 comments
Assignees

Comments

@borgmaan
Copy link
Collaborator

borgmaan commented Feb 7, 2023

A few items to clean up in the renv/GHA realm:

  • fontawesome should get upgraded to the compatible version (0.3.0) in renv.lock to avoid needing to re-install it during the execution (here, here, and here)
    • This will allow the app to be run without issue after renv::restore() and will save some time on each applicable GHA run
  • There is currently a warning thrown on all runs of r-lib/actions/setup-renv. This should be investigated and remedied if possible.
@AARON-CLARK
Copy link
Collaborator

  • fontawesome should get upgraded to the compatible version (0.3.0) in renv.lock to avoid needing to re-install it during the execution (here, here, and here)

@borgmaan, I was just thinking we should upgrade to the v0.5.0 release which came out two weeks ago so we can put the v0.4.0 drama in the past. Also, we can edit notes to mimic @Jeff-Thompson12's suggestion here.

@aclark02-arcus
Copy link
Collaborator

closed with #400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants