feat: response from dashboard include approvers detail #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwinkys
deleted the
19-response-from-dashboard-include-approvers-detail
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #19
This PR adds an approver data type which will be included in a response to the coordinator server when the approvers either approve or reject the request. We also add the approver name in the tracing after the server receives the response from the dashboard.
We also add a prompt for Approver Profile in the dashboard.
How Has This Been Tested?
I have tested it locally by running the server and simulating an approval request.
Checklist
This change's scope is within the dashboard and coordinator server functionality.