Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] approval response from dashboard include approver's detail #19

Closed
edwinkys opened this issue Nov 12, 2024 · 0 comments · Fixed by #20
Closed

[FEAT] approval response from dashboard include approver's detail #19

edwinkys opened this issue Nov 12, 2024 · 0 comments · Fixed by #20
Assignees
@edwinkys
Labels
enhancement New feature or request

Comments

@edwinkys
Copy link
Contributor

Feature Description

We want to include the approver's name when the dashboard send back an approval response to the server. This allows teams, specifically, to understand who has approved or rejected the approval request. This will also increase the robustness of the logging system.

Potential Solution

  • Dashboard should prompt for the name when connecting.
  • When sending an approval response back to the server, include the approver's name.
@edwinkys edwinkys added the enhancement New feature or request label Nov 12, 2024
@edwinkys edwinkys self-assigned this Nov 12, 2024
@edwinkys edwinkys mentioned this issue Nov 14, 2024
Merged
5 tasks
@edwinkys edwinkys linked a pull request Nov 14, 2024 that will close this issue
feat: response from dashboard include approvers detail #20
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edwinkys edwinkys

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: response from dashboard include approvers detail phantasmlabs/phantasm
1 participant
@edwinkys