Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Helm Chart #9

Merged
merged 15 commits into from
Nov 25, 2022
Merged

Support Helm Chart #9

merged 15 commits into from
Nov 25, 2022

Conversation

everpeace
Copy link
Contributor

@everpeace everpeace commented Nov 22, 2022 •
edited
Loading

depends on #8
fixes #6

This PR introduces helm chart support.

  • chart itself in charts/gcp-workload-identity-federation-webhook dir
  • chart is linted in GitHub Actions (ci.yaml)
  • release workflow is also paved by helm-gh-pages.
    • I tested the workflow in my forked repo.
    • index.yaml and chart tgz will be pushed in gh-pages branch. (sample in my fork)
    • So, you can try: 
      helm repo add gcp-workload-identity-federation-webhook https://everpeace.github.io/gcp-workload-identity-federation-webhook
helm repo update
helm show chart gcp-workload-identity-federation-webhook/gcp-workload-identity-federation-webhook

TODO

  • prepare empty gh-pages branch
  • configure Github Pages on gh-pages branch

@everpeace everpeace force-pushed the helm-chart branch 7 times, most recently from 9b547ff to 4c67ab5 Compare November 22, 2022 18:17
everpeace
everpeace commented Nov 22, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
charts/gcp-workload-identity-federation-webhook/Chart.yaml
Comment on lines +19 to +25
version: 0.0.0
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
# DEVELOPER'S NOTE: appVersion will be mutated in release process
appVersion: 0.0.0
Copy link
Contributor Author

@everpeace everpeace Nov 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version and appVersion will be injected in release.yaml
ref: #9 (comment)

.github/workflows/release.yaml
Comment on lines +42 to +43
app_version: ${{steps.tag.outputs.no_v}}
chart_version: ${{steps.tag.outputs.no_v}}
Copy link
Contributor Author

@everpeace everpeace Nov 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This injects version and appVersion in Chart.yaml
ref: #9 (comment)

@everpeace everpeace marked this pull request as ready for review November 22, 2022 18:27
everpeace
everpeace commented Nov 22, 2022
View reviewed changes
Copy link
Contributor Author

@everpeace everpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JorTurFer @superbrothers I wrote a helm chart and ci(lint)/release workflow. could you review this??

@JorTurFer
Copy link
Contributor

sure, tomorrow I'll review it. Thanks a lot! 🙇

superbrothers
superbrothers reviewed Nov 23, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
charts/gcp-workload-identity-federation-webhook/templates/deployment.yaml Show resolved Hide resolved
superbrothers
superbrothers reviewed Nov 24, 2022
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
superbrothers
superbrothers previously approved these changes Nov 24, 2022
View reviewed changes
JorTurFer
JorTurFer approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll add it to KEDA e2e tests once it's available and I can provide more info about if it works :)
Awesome job 🙇
Just one tip working with helm charts, you can use Kind in the GH Runner to deploy your charts to a local cluster, that could give you more feedback about invalid APIs or sections in the manifests. For instance, in KEDA we use it to validate the chart with several k8s versions

@everpeace
Copy link
Contributor Author

Just one tip working with helm charts, you can use Kind in the GH Runner to deploy your charts to a local cluster, that could give you more feedback about invalid APIs or sections in the manifests. For instance, in KEDA we use it to validate the chart with several k8s versions

Cool! I will try to do this in another PR.
I'm merging this PR for now and will release v0.1.1 to make helm chart available.

@everpeace everpeace merged commit 685f2f4 into main Nov 25, 2022
@everpeace everpeace deleted the helm-chart branch November 25, 2022 00:45
@github-actions github-actions bot mentioned this pull request Nov 25, 2022
Merged
@everpeace everpeace mentioned this pull request Nov 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@superbrothers superbrothers superbrothers approved these changes

Assignees
No one assigned
Labels
release-note/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm chart
3 participants
@everpeace @JorTurFer @superbrothers