Kill pkg_resources finders monkey-patching.
#827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer used any of this in production except for one `PEXBuilder` API which is converted to use `pex.pip` to install zipped wheels when encountered so that they can be found by standard `pkg_resources` finders. Tests that use zipped wheels are similaraly updated.
Eric-Arellano
approved these changes
Dec 12, 2019
Comment on lines
+330
to
+334
| spawn_install_wheel( | ||
| wheel=dist, | ||
| install_dir=dist_path, | ||
| target=DistributionTarget.for_interpreter(self.interpreter) | ||
| ).wait() |
There was a problem hiding this comment.
This part I'm unclear on. Is this an optimization or necessary to get things working?
There was a problem hiding this comment.
Its needed to kick our custom zipped-wheel finder to the curb. It's not an optimization since all wheels added to a pex are installed, not zipped (this goes back to a few commits after wheel support was added way back). Really, the zipped wheel finder support was only ~needed in tests and now that's killed too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer used any of this in production except for one
PEXBuilderAPI which is converted to use
pex.pipto install zipped wheels whenencountered so that they can be found by standard
pkg_resourcesfinders.
Tests that use zipped wheels are similarly updated.