Fix sys.path scrubbing of pex extras modules.
#752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would fail to scrub any extras modules imported by the pex bootstrapping code. Add failing unit and integration tests and fix this with a missing scrub step to check modules (previously only packages were scrubbed). Fixes pex-tool#745
|
@danmur I'm not sure if you have time to review, but the integration test added should make some sense and replicate your root poetry issue. See here if so: https://github.com/pantsbuild/pex/pull/752/files#diff-7eb47fc18d4a6196f0940784484a5bf3R1609 |
TansyArron
approved these changes
Aug 7, 2019
|
Thanks @TansyArron. I'm going to merge and circle back if there is further feedback. This is a small fix with the complexity all in the tests so I'm going to proceed with the 1.6.9 release to get this and #750 out there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would fail to scrub any extras modules imported by the pex
bootstrapping code. Add failing unit and integration tests and fix this
with a missing scrub step to check modules (previously only packages
were scrubbed).
Fixes #745