Fix pkg resource early import #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 30, 2019 16:57
…ate pkg_resources from namespace package
|
The CI error is reproducible locally. I'm taking a look... |
Remove a duplicate and buggy use of `pex_path` in `Pex.patch_sys`, fixup tests and "privatize" `PEXEnvironment` methods as appropriate for clarity.
+ Ensure pexes are added to the sys.path exactly once. + Surface explicit handling for the empty ns package list behavior seen in the wild - only consider non-empty lists.
jsirois
approved these changes
Aug 6, 2019
|
@jhamet93 could you please review the changes I made on top of yours? They are these: https://github.com/pantsbuild/pex/pull/750/files/62af44be964f6f916810a3ac4622241da1b34ff0..0489225aaa65cd41250b708e9210dd47a7e20695 Any comments would be great and if all looks good a LGTM would be good. Thanks for your contribution! |
|
LGTM. Thanks for the help finishing this one! |
This was referenced Aug 7, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As referenced in #749 , I ran into a situation where
pkg_resourceswas imported too early beforesys.pathwas finalized, occurring in the situation where a pex in myPEX_PATHneeded to invoke:pkg_resources.get_distribution. This was failing because a namespace package causedpkg_resourcesto be imported before the other pexes were merged into the environmentTherefore, wait until all deps from all pexes (i.e. pexes in
PEX_PATH) have been resolved before attempting to declare the namespace packages. This ensuressys.pathis finalized beforepkg_resourcesis possibly imported.