Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pex extraction perms. #528

Merged
merged 2 commits into from
Jul 23, 2018
Merged

Fix pex extraction perms. #528

merged 2 commits into from
Jul 23, 2018

Commits on Jul 21, 2018

  1. Fix pex extraction perms. 

    Previously, a zipped pex would lose permission bits when exracted to the
filesystem for `--not-zip-safe` pexes or `PEX_FORCE_LOCAL` runs. This
was due to an underlying bug in the `zipfile` stdlib tracked here:
  https://bugs.python.org/issue15795

Work around the bug in `zipfile.Zipfile` by extending it and running a
chmod'ing cleanup whenever `extract` or `extractall` is called.

Fixes pex-tool#527
    @jsirois
    jsirois committed Jul 21, 2018
    Configuration menu
    Copy the full SHA
    d51cf07 View commit details
    Browse the repository at this point in the history

  2. Fix import sorting.

    @jsirois
    jsirois committed Jul 21, 2018
    Configuration menu
    Copy the full SHA
    418dfdb View commit details
    Browse the repository at this point in the history