Fix pex extraction perms. #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a zipped pex would lose permission bits when exracted to the filesystem for `--not-zip-safe` pexes or `PEX_FORCE_LOCAL` runs. This was due to an underlying bug in the `zipfile` stdlib tracked here: https://bugs.python.org/issue15795 Work around the bug in `zipfile.Zipfile` by extending it and running a chmod'ing cleanup whenever `extract` or `extractall` is called. Fixes pex-tool#527
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a zipped pex would lose permission bits when exracted to the
filesystem for
--not-zip-safepexes orPEX_FORCE_LOCALruns. Thiswas due to an underlying bug in the
zipfilestdlib tracked here:https://bugs.python.org/issue15795
Work around the bug in
zipfile.Zipfileby extending it and running achmod'ing cleanup whenever
extractorextractallis called.Fixes #527