Plumb reproducible build env vars more thoroughly. #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps reduce cache sizes where sdists are built into wheels as well as expanding the set of sdists Pex can lock reproducibly.
jsirois
force-pushed
the
reproducible-builds/pip-and-pep-517
branch
from
c3c12e1
to
f173109
Compare
|
For the record, the Pip cache size difference where the cache is blown away, then |
jsirois
added a commit
to jsirois/unstructured
that referenced
this pull request
Oct 9, 2024
Without going the extra length of exporting `PYTHONHASHSEED=0` or similar, the built sdist and wheel for a given version of the project would have inconsistent random ordering of extras_require entries between builds. This was observed attempting to lock a VCS requirement on this project here: pantsbuild/pants#21145 On the bright side, it led to Pex fixing its building and locking code to be robust to this sort of (unintended) bad behavior: pex-tool/pex#2554
jsirois
added a commit
to jsirois/unstructured
that referenced
this pull request
Oct 9, 2024
Without going the extra length of exporting `PYTHONHASHSEED=0` or similar, the built sdist and wheel for a given version of the project would have inconsistent random ordering of extras_require entries between builds. This was observed attempting to lock a VCS requirement on this project here: pantsbuild/pants#21145 On the bright side, it led to Pex fixing its building and locking code to be robust to this sort of (unintended) bad behavior: pex-tool/pex#2554
|
Pants folks: added you FYI since this fixed a problem observed by a Pants user here: pantsbuild/pants#21145 and so you may want this release since that user didn't actually attempt to fix the underlying problem in the wild with the "unstructured" project's build. |
|
pantsbuild/pants#21545 upgrades Pants to use Pex 2.20.3, which includes this change. |
benjyw
added a commit
to pantsbuild/pants
that referenced
this pull request
Oct 17, 2024
To pick up various fixes, including pex-tool/pex#2554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps reduce cache sizes where sdists are built into wheels as well
as expanding the set of sdists Pex can lock reproducibly.