build: Fix build reproducibility. #3712
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without going the extra length of exporting `PYTHONHASHSEED=0` or similar, the built sdist and wheel for a given version of the project would have inconsistent random ordering of extras_require entries between builds. This was observed attempting to lock a VCS requirement on this project here: pantsbuild/pants#21145 On the bright side, it led to Pex fixing its building and locking code to be robust to this sort of (unintended) bad behavior: pex-tool/pex#2554
jsirois
commented
Oct 9, 2024
| @@ -56,7 +56,7 @@ def load_requirements(file_list: Optional[Union[str, List[str]]] = None) -> List | |||
| tsv_reqs = load_requirements("requirements/extra-csv.in") | |||
| xlsx_reqs = load_requirements("requirements/extra-xlsx.in") | |||
|
|
|||
| all_doc_reqs = list( | |||
| all_doc_reqs = sorted( | |||
There was a problem hiding this comment.
Although I added no reproducibility test to this repo, the Pex repo now has one inspired directly by the prior list(set(...)) construction. That test failed prior to Pex plumbing PYTHONHASHSEED=0 to all process where distributions are built: https://github.com/pex-tool/pex/pull/2554/files#diff-e405a0e10bc9facaca309df6d749de036226214e787bbcbc05ca0aa2f088bb95
|
@MthwRobinson it looks like you may be most appropriate to review. The problematic use of set appears to stem directly from #986. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without going the extra length of exporting
PYTHONHASHSEED=0orsimilar, the built sdist and wheel for a given version of the project
would have inconsistent random ordering of
extras_requireentriesbetween builds.
This was observed attempting to lock a VCS requirement on a fork of this
project here: pantsbuild/pants#21145
On the bright side, it led to Pex fixing its building and locking code
to be robust to this sort of (unintended) bad behavior:
pex-tool/pex#2554