fix infinite recursion when PEX_PYTHON points at a symlink #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landism
force-pushed
the
mlandis/pex_python_symlinks
branch
2 times, most recently
from
0549e4b
to
2beb556
Compare
landism
force-pushed
the
mlandis/pex_python_symlinks
branch
from
2beb556
to
1aeb863
Compare
|
merged @ a3b0a6a using the rbt workflow. closing. |
kwlzn
pushed a commit
to pantsbuild/pants
that referenced
this pull request
Dec 2, 2015
Changelog: ``` * Fix infinite recursion when ``PEX_PYTHON`` points at a symlink. #182 pex-tool/pex#182 * Add ``/etc/pexrc`` to the list of pexrc locations to check. #183 pex-tool/pex#183 * Improve error messaging for platform constrained Untranslateable errors. #179 pex-tool/pex#179 ``` Testing Done: https://travis-ci.org/pantsbuild/pants/builds/94480030 Bugs closed: 2654 Reviewed at https://rbcommons.com/s/twitter/r/3200/
peiyuwang
pushed a commit
to twitter/pants
that referenced
this pull request
Dec 4, 2015
Changelog: ``` * Fix infinite recursion when ``PEX_PYTHON`` points at a symlink. pantsbuild#182 pex-tool/pex#182 * Add ``/etc/pexrc`` to the list of pexrc locations to check. pantsbuild#183 pex-tool/pex#183 * Improve error messaging for platform constrained Untranslateable errors. pantsbuild#179 pex-tool/pex#179 ``` Testing Done: https://travis-ci.org/pantsbuild/pants/builds/94480030 Bugs closed: 2654 Reviewed at https://rbcommons.com/s/twitter/r/3200/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When PEX_PYTHON is in ~/.pexrc and set to a symlink, pex_bootstrapper repeatedly compares the symlink to the real path, determines they're not the same, and continues recursing. This goes on for hundreds of iterations until (it seems) something gets shoved out of the max env var length and the whole thing blows up because it can't find "locale".