Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messaging for platform constrained Untranslateable errors. #179

Merged
merged 1 commit into from
Nov 20, 2015
Merged

Improve error messaging for platform constrained Untranslateable errors. #179

merged 1 commit into from
Nov 20, 2015

Conversation

kwlzn
Copy link
Contributor

@kwlzn kwlzn commented Nov 13, 2015

before

[illuminati pex (master)]$ pex --no-pypi --find-links=http://science-binaries.local.twitter.com/home/third_party/python/ thrift==0.9.3 --platform=linux-x86_64
Traceback (most recent call last):
  File "/Users/kwilson/Python/CPython-2.7.10/bin/pex", line 9, in <module>
    load_entry_point('pex==1.1.0', 'console_scripts', 'pex')()
  File "build/bdist.macosx-10.4-x86_64/egg/pex/bin/pex.py", line 509, in main
  File "build/bdist.macosx-10.4-x86_64/egg/pex/bin/pex.py", line 471, in build_pex
  File "build/bdist.macosx-10.4-x86_64/egg/pex/resolver.py", line 199, in resolve
  File "build/bdist.macosx-10.4-x86_64/egg/pex/resolver.py", line 256, in build
  File "build/bdist.macosx-10.4-x86_64/egg/pex/resolver.py", line 170, in build
pex.resolver.Untranslateable: Could not get distribution for SourcePackage('file:///Users/kwilson/.pex/build/thrift-0.9.3.tar.gz') on appropriate platform.

after

[illuminati pex (kwlzn/platform_clarity)]$ pex --no-pypi --find-links=http://science-binaries.local.twitter.com/home/third_party/python/ thrift==0.9.3 --platform=linux-x86_64
Traceback (most recent call last):
  File "/Users/kwilson/Python/CPython-2.7.10/bin/pex", line 9, in <module>
    load_entry_point('pex==1.1.0', 'console_scripts', 'pex')()
  File "build/bdist.macosx-10.4-x86_64/egg/pex/bin/pex.py", line 509, in main
  File "build/bdist.macosx-10.4-x86_64/egg/pex/bin/pex.py", line 471, in build_pex
  File "build/bdist.macosx-10.4-x86_64/egg/pex/resolver.py", line 200, in resolve
  File "build/bdist.macosx-10.4-x86_64/egg/pex/resolver.py", line 257, in build
  File "build/bdist.macosx-10.4-x86_64/egg/pex/resolver.py", line 171, in build
pex.resolver.Untranslateable: Could not get distribution for SourcePackage('file:///Users/kwilson/.pex/build/thrift-0.9.3.tar.gz') on platform linux-x86_64.

@landism
Copy link
Contributor

landism commented Nov 20, 2015

:shipit:

kwlzn added a commit that referenced this pull request Nov 20, 2015
@kwlzn
Merge pull request #179 from kwlzn/kwlzn/platform_clarity
32fe780 
Improve error messaging for platform constrained Untranslateable errors.
@kwlzn kwlzn merged commit 32fe780 into pex-tool:master Nov 20, 2015
kwlzn pushed a commit to pantsbuild/pants that referenced this pull request Dec 2, 2015
@landism @kwlzn
Upgrade PEX to 1.1.1
6505065 
Changelog:
```
* Fix infinite recursion when ``PEX_PYTHON`` points at a symlink.
  #182 pex-tool/pex#182

* Add ``/etc/pexrc`` to the list of pexrc locations to check.
  #183 pex-tool/pex#183

* Improve error messaging for platform constrained Untranslateable errors.
  #179 pex-tool/pex#179
```

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/94480030

Bugs closed: 2654

Reviewed at https://rbcommons.com/s/twitter/r/3200/
peiyuwang pushed a commit to twitter/pants that referenced this pull request Dec 4, 2015
@landism
Upgrade PEX to 1.1.1
7176164 
Changelog:
```
* Fix infinite recursion when ``PEX_PYTHON`` points at a symlink.
  pantsbuild#182 pex-tool/pex#182

* Add ``/etc/pexrc`` to the list of pexrc locations to check.
  pantsbuild#183 pex-tool/pex#183

* Improve error messaging for platform constrained Untranslateable errors.
  pantsbuild#179 pex-tool/pex#179
```

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/94480030

Bugs closed: 2654

Reviewed at https://rbcommons.com/s/twitter/r/3200/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwlzn @landism