Skip to content

Commit

Permalink
Add retry and enable UTs for Windows
Browse files Browse the repository at this point in the history
Added a retry around the the bootstrap that previously failed due to network issues.  Ran the new version of this workflow 100x on linux and 100x on windows, both passed at 100% [1].

Without the retry during a run of 100 times iterations [2], the windows test failed once during the bootstrap.  If we see future issues, we could attempt to add retries to them following this same pattern.

[1] https://github.com/peternied/security-dashboards-plugin/actions/runs/3449518073
[2] https://github.com/peternied/security-dashboards-plugin/actions/runs/3449040181

- Resolves opensearch-project#1211
- Resolves opensearch-project#1195

Signed-off-by: Peter Nied <[email protected]>
  • Loading branch information
peternied committed Nov 14, 2022
1 parent 257325c commit 48abaa3
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
8 changes: 5 additions & 3 deletions .github/actions/install-dashboards/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ runs:
working-directory: OpenSearch-Dashboards
shell: bash
- run: yarn osd bootstrap --oss
working-directory: OpenSearch-Dashboards
shell: bash
- uses: nick-fields/retry@v2
with:
timeout_minutes: 20
max_attempts: 2
command: yarn --cwd OpenSearch-Dashboards osd bootstrap --oss
6 changes: 5 additions & 1 deletion .github/workflows/unit-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,14 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ ubuntu-latest, macos-latest ]
os: [ ubuntu-latest , windows-latest, macos-latest ]
runs-on: ${{ matrix.os }}

steps:
- name: Enable longer filenames
if: ${{ matrix.os == 'windows-latest' }}
run: git config --system core.longpaths true

- uses: actions/checkout@v2

- id: install-dashboards
Expand Down

0 comments on commit 48abaa3

Please sign in to comment.