Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Failures] UTs Are Flaky on Windows. To Fix and Re-enable Later. #1211

Closed
cliu123 opened this issue Nov 11, 2022 · 0 comments · Fixed by #1215
Closed

[Test Failures] UTs Are Flaky on Windows. To Fix and Re-enable Later. #1211

cliu123 opened this issue Nov 11, 2022 · 0 comments · Fixed by #1215
Labels
bug Something isn't working untriaged

Comments

@cliu123
Copy link
Member

cliu123 commented Nov 11, 2022

What is the bug?

UTs Are Flaky on Windows. Disabling it for now with #1202. It will be re-enabled after a fix gets applied.

The error could help narrow down the root cause. @peternied If no plan to fix this, then I don't see value to keep it run for now. It should be disabled until it gets stablized.

2022-11-03T04:08:57.2968807Z info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
2022-11-03T04:08:57.5331813Z info There appears to be trouble with your network connection. Retrying...
2022-11-03T04:10:18.3867635Z ERROR [bootstrap] failed:
2022-11-03T04:10:18.3870994Z ERROR Error: Command failed with exit code 1: C:\npm\prefix\node_modules\yarn\bin\yarn.js install --non-interactive
2022-11-03T04:10:18.3872060Z           at makeError (D:\a\security-dashboards-plugin\security-dashboards-plugin\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:25150:11)
2022-11-03T04:10:18.3879284Z           at handlePromise (D:\a\security-dashboards-plugin\security-dashboards-plugin\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:24085:26)
2022-11-03T04:10:18.3880256Z           at processTicksAndRejections (internal/process/task_queues.js:95:5)
2022-11-03T04:10:18.3881649Z           at async installInDir (D:\a\security-dashboards-plugin\security-dashboards-plugin\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:23821:3)
2022-11-03T04:10:18.3883826Z           at async Project.installDependencies (D:\a\security-dashboards-plugin\security-dashboards-plugin\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:14780:5)
2022-11-03T04:10:18.3890831Z           at async Object.run (D:\a\security-dashboards-plugin\security-dashboards-plugin\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:9003:11)
2022-11-03T04:10:18.3892253Z           at async runCommand (D:\a\security-dashboards-plugin\security-dashboards-plugin\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:57870:5)
2022-11-03T04:10:18.3895322Z           at async Module.run (D:\a\security-dashboards-plugin\security-dashboards-plugin\OpenSearch-Dashboards\packages\osd-pm\dist\index.js:263:3)
@cliu123 cliu123 added bug Something isn't working untriaged labels Nov 11, 2022
peternied added a commit to peternied/security-dashboards-plugin that referenced this issue Nov 14, 2022
Added a retry around the the bootstrap that previously failed due to network issues.  Ran the new version of this workflow 100x on linux and 100x on windows, both passed at 100% [1].

Without the retry during a run of 100 times iterations [2], the windows test failed once during the bootstrap.  If we see future issues, we could attempt to add retries to them following this same pattern.

[1] https://github.com/peternied/security-dashboards-plugin/actions/runs/3449518073
[2] https://github.com/peternied/security-dashboards-plugin/actions/runs/3449040181

- Resolves opensearch-project#1211
- Resolves opensearch-project#1195

Signed-off-by: Peter Nied <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant