-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added default table and snapshot container names #99
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ad9acf7
Added default table and container names
IgorFedchenko 6e9e297
Refactored and added specs
IgorFedchenko 3b2c14d
Fixed default empty values
IgorFedchenko a35d3db
Moved default names to HOCON
IgorFedchenko 7f0d11a
Fixed specs
IgorFedchenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,6 +16,11 @@ namespace Akka.Persistence.Azure.Snapshot | |
/// </summary> | ||
public sealed class AzureBlobSnapshotStoreSettings | ||
{ | ||
/// <summary> | ||
/// Container name used as a fallback configuration value | ||
/// </summary> | ||
public const string DefaultContainerName = "akka-persistence-default-container"; | ||
|
||
public AzureBlobSnapshotStoreSettings(string connectionString, string containerName, | ||
TimeSpan connectTimeout, TimeSpan requestTimeout, bool verboseLogging) | ||
{ | ||
|
@@ -61,11 +66,20 @@ public AzureBlobSnapshotStoreSettings(string connectionString, string containerN | |
public static AzureBlobSnapshotStoreSettings Create(Config config) | ||
{ | ||
var connectionString = config.GetString("connection-string"); | ||
var containerName = config.GetString("container-name"); | ||
var connectTimeout = config.GetTimeSpan("connect-timeout", TimeSpan.FromSeconds(3)); | ||
var requestTimeout = config.GetTimeSpan("request-timeout", TimeSpan.FromSeconds(3)); | ||
var verbose = config.GetBoolean("verbose-logging", false); | ||
return new AzureBlobSnapshotStoreSettings(connectionString, containerName, connectTimeout, requestTimeout, | ||
var containerName = config.GetString("container-name", DefaultContainerName); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above about loading name in runtime. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These values should be stored in HOCON. |
||
|
||
// When value is not overriden after default config, still may have null/"" here | ||
if (string.IsNullOrWhiteSpace(containerName)) | ||
containerName = DefaultContainerName; | ||
|
||
return new AzureBlobSnapshotStoreSettings( | ||
connectionString, | ||
containerName, | ||
connectTimeout, | ||
requestTimeout, | ||
verbose); | ||
} | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize that easier way would be to set this default names in default hocon configuration - but this way users will be able to get name value from
DefaultTableName
constant in runtime. Which might be useful.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These values should be stored in HOCON.