-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added default table and snapshot container names #99
Conversation
@@ -75,10 +79,14 @@ public sealed class AzureTableStorageJournalSettings | |||
public static AzureTableStorageJournalSettings Create(Config config) | |||
{ | |||
var connectionString = config.GetString("connection-string"); | |||
var tableName = config.GetString("table-name"); | |||
var tableName = config.GetString("table-name", DefaultTableName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize that easier way would be to set this default names in default hocon configuration - but this way users will be able to get name value from DefaultTableName
constant in runtime. Which might be useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These values should be stored in HOCON.
var connectTimeout = config.GetTimeSpan("connect-timeout", TimeSpan.FromSeconds(3)); | ||
var requestTimeout = config.GetTimeSpan("request-timeout", TimeSpan.FromSeconds(3)); | ||
var verbose = config.GetBoolean("verbose-logging", false); | ||
return new AzureBlobSnapshotStoreSettings(connectionString, containerName, connectTimeout, requestTimeout, | ||
var containerName = config.GetString("container-name", DefaultContainerName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above about loading name in runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These values should be stored in HOCON.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to have these loaded from the HOCON settings under the covers, rather than a constant value.
@@ -75,10 +79,14 @@ public sealed class AzureTableStorageJournalSettings | |||
public static AzureTableStorageJournalSettings Create(Config config) | |||
{ | |||
var connectionString = config.GetString("connection-string"); | |||
var tableName = config.GetString("table-name"); | |||
var tableName = config.GetString("table-name", DefaultTableName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These values should be stored in HOCON.
var connectTimeout = config.GetTimeSpan("connect-timeout", TimeSpan.FromSeconds(3)); | ||
var requestTimeout = config.GetTimeSpan("request-timeout", TimeSpan.FromSeconds(3)); | ||
var verbose = config.GetBoolean("verbose-logging", false); | ||
return new AzureBlobSnapshotStoreSettings(connectionString, containerName, connectTimeout, requestTimeout, | ||
var containerName = config.GetString("container-name", DefaultContainerName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These values should be stored in HOCON.
Oops, CI failed |
Should be good to go now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Close #63