Added default table and snapshot container names #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorFedchenko
commented
Jul 10, 2020
| @@ -75,10 +79,14 @@ public sealed class AzureTableStorageJournalSettings | |||
| public static AzureTableStorageJournalSettings Create(Config config) | |||
| { | |||
| var connectionString = config.GetString("connection-string"); | |||
| var tableName = config.GetString("table-name"); | |||
| var tableName = config.GetString("table-name", DefaultTableName); | |||
There was a problem hiding this comment.
I realize that easier way would be to set this default names in default hocon configuration - but this way users will be able to get name value from DefaultTableName constant in runtime. Which might be useful.
There was a problem hiding this comment.
These values should be stored in HOCON.
IgorFedchenko
commented
Jul 10, 2020
| var connectTimeout = config.GetTimeSpan("connect-timeout", TimeSpan.FromSeconds(3)); | ||
| var requestTimeout = config.GetTimeSpan("request-timeout", TimeSpan.FromSeconds(3)); | ||
| var verbose = config.GetBoolean("verbose-logging", false); | ||
| return new AzureBlobSnapshotStoreSettings(connectionString, containerName, connectTimeout, requestTimeout, | ||
| var containerName = config.GetString("container-name", DefaultContainerName); |
There was a problem hiding this comment.
Same as above about loading name in runtime.
There was a problem hiding this comment.
These values should be stored in HOCON.
Aaronontheweb
requested changes
Jul 10, 2020
| @@ -75,10 +79,14 @@ public sealed class AzureTableStorageJournalSettings | |||
| public static AzureTableStorageJournalSettings Create(Config config) | |||
| { | |||
| var connectionString = config.GetString("connection-string"); | |||
| var tableName = config.GetString("table-name"); | |||
| var tableName = config.GetString("table-name", DefaultTableName); | |||
There was a problem hiding this comment.
These values should be stored in HOCON.
| var connectTimeout = config.GetTimeSpan("connect-timeout", TimeSpan.FromSeconds(3)); | ||
| var requestTimeout = config.GetTimeSpan("request-timeout", TimeSpan.FromSeconds(3)); | ||
| var verbose = config.GetBoolean("verbose-logging", false); | ||
| return new AzureBlobSnapshotStoreSettings(connectionString, containerName, connectTimeout, requestTimeout, | ||
| var containerName = config.GetString("container-name", DefaultContainerName); |
There was a problem hiding this comment.
These values should be stored in HOCON.
|
Oops, CI failed |
|
Should be good to go now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #63