(stdlib) Use better format in float and double conversion to string
#414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm marking this a Draft for now; we want to ensure we can really produce the exact same format in #409 (on top of this MR) before we consider it worth merging. |
perlun
commented
Nov 1, 2023
3 tasks
The main benefit of this new format is that it's "more" predictable, and we can more easily mimic the exact byte-by-byte output in the C++ implementation. The downside is that we *may* have problems with roundtripping to string and back with this format, because of precision loss. Let's live with this for now; it's (for now) more important that all integration tests pass in compiled and interpreted mode. .NET Framework seems to have been using G7 and G15 by default, so it can't be that bad. ;)
perlun
force-pushed
the
fix/avoid-expontential-notation-for-certain-floating-point-numbers
branch
from
8b6f2ae
to
e04217e
Compare
perlun
changed the title
float and double conversion to stringfloat and double conversion to string
This has now been verified. I'm scheduling this for merge in a moment. 🎉 |
perlun
added
enhancement
perlun
deleted the
fix/avoid-expontential-notation-for-certain-floating-point-numbers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main benefit of this new format is that it's "more" predictable, and we can more easily mimic the exact byte-by-byte output in the C++ implementation.
The downside is that we may have problems with roundtripping to string and back with this format, because of precision loss. Let's live with this for now; it's (for now) more important that all integration tests pass in compiled and interpreted mode. .NET Framework seems to have been using G7 and G15 by default, so it can't be that bad. ;)