Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(compiler) Add first steps towards experimental compiler #409

Merged
merged 1 commit into from
Nov 2, 2023
Merged

(compiler) Add first steps towards experimental compiler #409

merged 1 commit into from
Nov 2, 2023

Conversation

perlun
Copy link
Collaborator

@perlun perlun commented Sep 29, 2023 •
edited
Loading

  • All tests are now passing in compiled (and interpreted) mode.
  • CI settings have been adjusted so that we test interpreted mode on all supported platforms, and in addition to this, we test compiled mode on Ubuntu

What remains to be done:

  • Compile and include the stdlib along with our release distributions, so that compiled mode is usable in these as well. This will be done in a followup MR.

@perlun perlun added enhancement New feature or request experimental compilation Issues which are relevant when using experimental compilation labels Sep 29, 2023
@perlun perlun added this to the 0.4.0 milestone Sep 29, 2023
@perlun perlun force-pushed the feature/add-experimental-compilation branch 2 times, most recently from 03ffba8 to 4b8ffea Compare October 1, 2023 10:57
@perlun perlun mentioned this pull request Oct 1, 2023
Closed
12 tasks
@perlun perlun force-pushed the feature/add-experimental-compilation branch 3 times, most recently from a8a2738 to 94e672a Compare October 1, 2023 11:14
perlun added a commit that referenced this pull request Oct 1, 2023
@perlun
(test) Minor test improvements
1f88e9c 
Extracted from changes originally done in
#409, to keep the git history
a bit more tidy.
@perlun perlun mentioned this pull request Oct 1, 2023
Merged
perlun added a commit that referenced this pull request Oct 1, 2023
@perlun
(test) Minor test improvements (#410)
69367d3 
Extracted from changes originally done in
#409, to keep the git history
a bit more tidy.
@perlun perlun force-pushed the feature/add-experimental-compilation branch 2 times, most recently from 95cace8 to 8f79943 Compare October 1, 2023 19:18
@perlun perlun force-pushed the feature/add-experimental-compilation branch from 8d424b4 to 9a711c2 Compare October 13, 2023 18:59
@perlun perlun mentioned this pull request Oct 16, 2023
Closed
perlun added a commit that referenced this pull request Oct 16, 2023
@perlun
(parser) Preserve exact floating point representation when parsing
dee2f3f 
This will be useful in the compilation part (#409), where we want to
avoid losing precision because of round-tripping.
perlun added a commit that referenced this pull request Oct 17, 2023
@perlun
(parser) Preserve exact floating point representation when parsing
e9bcf15 
This will be useful in the compilation part (#409), where we want to
avoid losing precision because of round-tripping.
@perlun perlun mentioned this pull request Oct 17, 2023
Merged
perlun added a commit that referenced this pull request Oct 17, 2023
@perlun
(parser) Preserve exact floating point representation when parsing
9b4a133 
This will be useful in the compilation part (#409), where we want to
avoid losing precision because of round-tripping.
perlun added a commit that referenced this pull request Oct 17, 2023
@perlun
(parser) Preserve exact floating point representation
56b4d59 
The idea is to avoid losing the exact floating point representation as
given by the user when constructing the parsed syntax tree. This will be
useful in the compilation part (#409), where we want to avoid losing
precision because of round-tripping to `double` and back to `string`.
perlun added a commit that referenced this pull request Oct 17, 2023
@perlun
(parser) Preserve exact floating point representation
b3b0953 
The idea is to avoid losing the exact floating point representation as
given by the user when constructing the parsed syntax tree. This will be
useful in the compilation part (#409), where we want to avoid losing
precision because of round-tripping to `double` and back to `string`.
perlun added a commit that referenced this pull request Oct 17, 2023
@perlun
(parser) Preserve exact floating point representation (#412)
28f6dae 
The idea is to avoid losing the exact floating point representation as
given by the user when constructing the parsed syntax tree. This will be
useful in the compilation part (#409), where we want to avoid losing
precision because of round-tripping to `double` and back to `string`.
@perlun perlun force-pushed the feature/add-experimental-compilation branch 3 times, most recently from 5dd1501 to 4909721 Compare October 20, 2023 19:29
perlun added a commit that referenced this pull request Oct 22, 2023
@perlun
(interpreter) Make int == double use value-type semantics
b44e45f 
This is an important preparation for
#409, where we will use the
same semantics. Doing the change already not for interpreted mode makes
things easier, since we can then use the same tests for both interpreted
and compiled mode.
@perlun perlun mentioned this pull request Oct 22, 2023
Merged
perlun added a commit that referenced this pull request Oct 22, 2023
@perlun
(interpreter) Make int == double use value-type semantics (#413)
8f6e529 
This is an important preparation for
#409, where we will use the
same semantics. Doing the change already not for interpreted mode makes
things easier, since we can then use the same tests for both interpreted
and compiled mode.
perlun added a commit that referenced this pull request Oct 27, 2023
@perlun
(interpreter) Make int == double use value-type semantics (#413)
50b1ff9 
This is an important preparation for
#409, where we will use the
same semantics. Doing the change already now for interpreted mode makes
things easier, since we can then use the same tests for both interpreted
and compiled mode.
@perlun perlun force-pushed the feature/add-experimental-compilation branch from 4909721 to 59d255f Compare October 27, 2023 20:01
@perlun perlun mentioned this pull request Oct 30, 2023
Merged
@perlun
Copy link
Collaborator Author

perlun commented Nov 1, 2023

we have about 93 tests (out of 1934) failing

For those watching this PR (if any): this is no way abandoned, it's just taking a bit of time to finish. I'm currently down to 5 test failures, on top of #414. All the other issues have been dealt with.

@perlun
Copy link
Collaborator Author

perlun commented Nov 1, 2023 •
edited
Loading

Believe it or not but after a whopping five months of (active and passive) work, this is now ready for merge. 🎉 The only remaining thing is to ensure that we run the tests in compiled mode also in CI. I'll see if we can get that fixed now.

@perlun perlun force-pushed the feature/add-experimental-compilation branch 7 times, most recently from b1b487c to a9b5d94 Compare November 1, 2023 21:56
@perlun
Copy link
Collaborator Author

perlun commented Nov 1, 2023 •
edited
Loading

The only remaining thing is to ensure that we run the tests in compiled mode also in CI. I'll see if we can get that fixed now.

This has now been added, and the experimental compilation is failing in CI. I'll deal with this ASAP, before we'll get this merged.

@perlun perlun force-pushed the feature/add-experimental-compilation branch from a9b5d94 to 4c4e44c Compare November 2, 2023 19:49
@perlun perlun force-pushed the feature/add-experimental-compilation branch 2 times, most recently from f4bdbc8 to b3c85e1 Compare November 2, 2023 20:30
@perlun perlun merged commit b389144 into master Nov 2, 2023
14 checks passed
@perlun perlun deleted the feature/add-experimental-compilation branch November 2, 2023 20:44
perlun added a commit that referenced this pull request Nov 2, 2023
@perlun
(compiler) Add first steps towards experimental compiler (#409)
8e894cd
@perlun
Copy link
Collaborator Author

perlun commented Nov 3, 2023

See #406 for the bigger picture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request experimental compilation Issues which are relevant when using experimental compilation
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@perlun