-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(many) Upgrade to .NET 7 RC1 #347
Conversation
66d30fa
to
cbcf67c
Compare
029f0ac
to
abcfc05
Compare
Most automated test seem to work nicely OOTB. The only issue found thus far is this, from https://github.com/perlang-org/perlang/actions/runs/3184319266/jobs/5192588306:
I can easily reproduce this locally, and it seems to have something to do with the (dynamic) loading of the stdlib |
Something does indeed go wrong. Thanks to In an existing build based on 78fbc1f, built with .NET 6
The above list is correct; those types are expected to be present in this assembly. Now, take a look at the corresponding output in the .NET build... In a build generated from the contents in this PR
TL;DR: Something goes terribly wrong when we build the
1: 🙏 available in |
I guess this could be causing it: https://devblogs.microsoft.com/dotnet/announcing-dotnet-7-preview-7/#trimming-and-nativeaot-all-assemblies-trimmed-by-default
|
This comment was marked as outdated.
This comment was marked as outdated.
abcfc05
to
e90824d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Argh, I was looking at the wrong file. 🙈 🤯 The problem still seems to persist, which CI was kind enough to highlight...
|
e90824d
to
33edd1d
Compare
The problem has now been resolved, with some help from the MS guys. 🙏 Given that .NET 7 is likely to ship before Perlang 0.3.0, let's get this merged now. 👍 |
33edd1d
to
23622b0
Compare
.NET 7 is not yet released; it's likely to be released next month. This PR tries to see how well-prepared we are for it. 🙂