-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(many) Upgrade to .NET 6 #223
Conversation
5bca247
to
f19de1d
Compare
8436d86
to
0112a8c
Compare
@@ -2,7 +2,8 @@ | |||
<!-- C# analyzers configuration --> | |||
<PropertyGroup> | |||
<CodeAnalysisRuleSet>$(SolutionDir)global.ruleset</CodeAnalysisRuleSet> | |||
<TargetFramework>net5.0</TargetFramework> | |||
<TargetFramework>net6.0</TargetFramework> | |||
<SuppressTrimAnalysisWarnings>true</SuppressTrimAnalysisWarnings> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suppressing trimmer analysis warnings might seem a bit foolish, but I'm not sure littering the code with tons of attributes to suppress them is really the way forward for us. Let's for now assume the "dynamic programming language" approach instead - let's catch errors with unit tests instead of static analysis. 🤪
Time will tell whether this is insane or simply a stroke of genius...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Time will tell whether this is insane or simply a stroke of genius...
Well. It hit us in #347, making these trimming warnings be invisible by default... 😎 See #347 (comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should try to solve this. Created an issue to track the work related to it: #348
0112a8c
to
133c324
Compare
No description provided.