(docs) Make <pre> code be readable in dark mode also #179
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlun
force-pushed
the
fix/pre-code-unreadable-in-dark-mode
branch
from
1f32a59 to
8aea4d0
Compare
perlun
commented
Apr 9, 2021
| @@ -14,6 +14,9 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v1 | |||
|
|
|||
| - name: Install SASS | |||
| run: npm install -g sass | |||
|
|
|||
There was a problem hiding this comment.
The CI failed in https://github.com/perlang-org/perlang/pull/179/checks?check_run_id=2308969743; this change is here to try and fix that. I don't really understand why it tried to rebuild the CSS stylesheet though, but I'm guessing the timestamp of the .scss file was never than the .css file in this case. It has worked until now, probably because the order of the timestamps was the reverse in all CI runs until this one.
perlun
force-pushed
the
fix/pre-code-unreadable-in-dark-mode
branch
from
8aea4d0 to
a8a2872
Compare
perlun
pushed a commit
to perlun/darkerfx
that referenced
this pull request
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an additional fix for #174. Without this, the text used #333 on black (#000) background, which is rather hard to read, to say the least.
This change retains the #333 color in light mode (where it makes sense), but changes to use
inheritin dark mode, which looks much better.