-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mode switcher & dark DocFx theme #174
Comments
This has been mostly accomplished as of #175 being merged yesterday, but there are still some issues to sort out before we can consider this closed:
Problems with font size being too bigI also found another slight "issue", not particularly related to the mode switcher but to the increased font size (changed in c5c0dac). It doesn't look particularly good now on "low-DPI" monitors, such as the FHD 23" screen I have here connected to our desktop machine here in my home. I looked into this, but it's a particularly tricky problem to solve, since Firefox reports 96dpi on both that machine and on the laptop where I'm writing this. This is of course completely untrue since one is a 23" screen and the other a 309mm x 174mm laptop screen. Given the complexity in solving this, I think we'll live with this for the time being. 😬 |
Fixed in perlun/darkerfx@5bd8d97
This bug is btw also present in I also found another horribly looking bug, only visible on mobile. If you click Show / Hide Table of Contents one or more times, you can run into this: |
Not reproducible on iOS with a "real" mobile device, only with iPhone simulator in Firefox DevTools. Ignoring this bug for now as long as we cannot reproduce it on mobile. |
Fixed in #176; upstreamed to darkerfx in perlun/darkerfx#2
This seems to be a known issue upstream btw: steffen-wilke/darkfx#5 |
On second thought, this is not something that seems to be universally present. Here are my current findings:
Bottom lineI'm not in any way against adding this feature, I just don't want to spend my own precious time on it. I'll file a follow-up issue about it, outlining the details if someone is interested in picking it up: #177. I'll consider this issue completed now, closing issue. |
steffen-wilke/darkfx#1 should have the info required to implement this.
The text was updated successfully, but these errors were encountered: