Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors related to niluser_defined value #65

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Fix errors related to niluser_defined value #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c428a52
fix indexing for case where user_defined field is nil
camdendotlol Feb 20, 2024
3d940f3
add null check to public endpoint too
camdendotlol Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/serializers/core_data_connector/public/user_defined_serializer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ def render_user_defined(item, fields, hash)
return if fields.nil?

fields.each do |field|
next unless item.user_defined

value = item.user_defined[field.uuid]
next if value.nil?

Expand All @@ -40,4 +42,4 @@ def render_user_defined(item, fields, hash)
end
end
end
end
end
2 changes: 2 additions & 0 deletions app/services/core_data_connector/search/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,8 @@ def build_user_defined(record, user_defined_fields)
hash = {}

user_defined_fields.each do |field|
next unless record.user_defined

value = record.user_defined[field.uuid]
next unless value.present?

Expand Down