Fix errors related to niluser_defined value
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camdendotlol
changed the title
user_defined field is niluser_defined field is nil
camdendotlol
changed the title
user_defined field is nilniluser_defined value
dleadbetter
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This small PR fixes two issues where Core Data tried to access a user-defined field by its UUID without first checking if the
user_definedfield was actually a JSON object. An empty user-defined field can be either{}(an empty object) ornil, so I've fixed the issue by checking thatuser_definedisn'tnilbefore proceeding to try to look up a value in it.