Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDC #323 - Make 'name' string field sortable during typesense schema creation #109

Merged
merged 2 commits into from
Dec 6, 2024
Merged

CDC #323 - Make 'name' string field sortable during typesense schema creation #109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fa7e11
Make 'name' string field sortable during typesense schema creation
blms Dec 5, 2024
80173b7
Make name optional in index schema config (performant-software/core-d…
blms Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/typesense/helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@ def create
type: 'geopoint',
facet: false,
optional: true
}, {
name: 'name',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to make this optional. All records should have a name attribute, but in the event that one doesn't (due to an import error or something) we don't want to prevent the project from being indexed.

type: 'string',
sort: true,
optional: true
}, {
name: '.*_facet',
type: 'auto',
Expand Down