CDC #323 - Make 'name' string field sortable during typesense schema creation #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blms
changed the title
blms
force-pushed
the
feature/sort-by-name
branch
from
f64adf6 to
8fa7e11
Compare
dleadbetter
reviewed
Dec 6, 2024
lib/typesense/helper.rb
Outdated
| type: 'string', | ||
| sort: true | ||
| },{ | ||
| name: 'name_facet', |
There was a problem hiding this comment.
I'm going to walk back my previous note, I don't think we'll need name_facet to be sortable.
dleadbetter
reviewed
Dec 6, 2024
There was a problem hiding this comment.
Just one comment about my incorrect directions 🙃 . I've also created #323, which can be linked to this PR. Also if you could label this PR with "next release".
dleadbetter
reviewed
Dec 6, 2024
| @@ -34,6 +34,15 @@ def create | |||
| type: 'geopoint', | |||
| facet: false, | |||
| optional: true | |||
| }, { | |||
| name: 'name', | |||
There was a problem hiding this comment.
We may want to make this optional. All records should have a name attribute, but in the event that one doesn't (due to an import error or something) we don't want to prevent the project from being indexed.
|
Tested locally and it works! My collection created from this task now has the options to sort on |
blms
force-pushed
the
feature/sort-by-name
branch
from
baf1344 to
80173b7
Compare
dleadbetter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
Per Atlas and performant-software/core-data-cloud#323, allow sorting on the
nameandname_facetfields.Notes