Support linting remote GitHub projects via the API #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,53 @@ | |||
| package flint | |||
|
|
|||
| type LintError struct { | |||
There was a problem hiding this comment.
Are you planning to make this implement the Error interface?
|
Thanks @jingweno! 🤘 I made those changes and some other cleanup. ea93e9a...6f8f4b2 |
|
👍 |
pengwynn
added a commit
that referenced
this pull request
Dec 13, 2014
Support linting remote GitHub projects via the API
cmhokej
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pretty big chunk of changes, this PR provides support for linting remote projects by passing
--github owner/repoin the command line (so you don't have to clone the project locally). I want to use some of this code in a small web app, so I tried to separate the CLI stuff from the rest of the library.Since I'm still learning idiomatic Go, I'd ❤️ some 👀 from @penland365, @jingweno, and @rubyist if y'all have the time.