Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail on read errors #178

Merged
merged 5 commits into from
Dec 7, 2016
Merged

Fail on read errors #178

merged 5 commits into from
Dec 7, 2016

Commits on Dec 6, 2016

  1. Expand test_stream function to support error handlers 

    In order to assert that code properly handles errors emitted in the
stream being tested, test_stream now supports an optional error handling
callback.
    @orangejulius
    orangejulius committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    f61e3d9 View commit details
    Browse the repository at this point in the history

  2. Throw error in loadJSON stream when JSON parsing fails 

    Previously, the import would continue with just that file being skipped.
    @orangejulius
    orangejulius committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    f13074d View commit details
    Browse the repository at this point in the history

  3. Test that error is thrown when a file can't be read

    @orangejulius
    orangejulius committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    ab86027 View commit details
    Browse the repository at this point in the history

  4. Improve JSON parsing error message

    @orangejulius
    orangejulius committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    0896d40 View commit details
    Browse the repository at this point in the history

  5. Use full path in file reading error

    @orangejulius
    orangejulius committed Dec 6, 2016
    Configuration menu
    Copy the full SHA
    90cbc3d View commit details
    Browse the repository at this point in the history