Fail on read errors #178
Merged
Fail on read errors #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to assert that code properly handles errors emitted in the stream being tested, test_stream now supports an optional error handling callback.
Previously, the import would continue with just that file being skipped.
trescube
approved these changes
Dec 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The importer previously wasn't very strict about actually doing something about errors while reading files. It would swallow errors from failing to parse JSON, and not log anything extra when it couldn't read a file. Now it halts on both cases with error messages.
This took some changing to our little
test_streamfunction, which is now getting complex enough I think we should move it to its own package soon. Additionally I had to movet.end()to the actual end of the callbacks from the stream, afterstdoutinterception is stopped, or we can't properly track error output in the next test. I'd love to hear if anyone has ideas to make the test code cleaner, but I think it's ok.