Configurable Geonames download URL #299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes care of #239
The
download
function can now take a custom url - defined in the config file asimports.geonames.sourceURL
from which to download a file. IfsourceURL
is undefined or an empty string the code defaults to the official Geonames dumps. The defined url can be a "template literal" format where${countryCode}
will be evaluated with the givencountryCode
.Other changes (let me know if these should be broken out to other PRs or tossed entirely):
bin/download_data.js
main code out to lib/task/download.js to match template of other filesbin/download_data.js
tobin/downloadData.js
to match camelCase format of other files