Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The URL to download Geonames data from should be configurable #239

Closed
orangejulius opened this issue Sep 20, 2017 · 1 comment
Closed

The URL to download Geonames data from should be configurable #239

orangejulius opened this issue Sep 20, 2017 · 1 comment
Labels
good first issue help wanted ideas

Comments

@orangejulius
Copy link
Member

We have had frequent problems with downloading geonames data from the very beginning of this project. Not too long ago, we created a script to verify a given Geonames download so that we can mirror successful downloads to our own S3 bucket.

That is all set up, incuding the mirroring. However, the importer hardcodes the URL to download from, so it's not possible to use this!

https://github.com/pelias/geonames/blob/master/lib/tasks/download.js#L11

Ideally pelias.json could specify an alternate URL to download from.
@tpedelose tpedelose mentioned this issue May 2, 2018
Merged
@orangejulius
Copy link
Member Author

Fixed in #299, thanks @Tiranno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted ideas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orangejulius