Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimating points and saving them #381

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Estimating points and saving them #381

merged 5 commits into from
Sep 19, 2024

Conversation

pawell24
Copy link
Contributor

@pawell24 pawell24 commented Sep 18, 2024

The code in this PR includes estimating points in request links and sending them to the database after completing the link.

Summary by CodeRabbit

  • New Features

    • Introduced points estimation functionality in the payment process, providing users with feedback on potential rewards based on transaction details.
    • Enhanced transaction display to show estimated points and converted token amounts in USD, improving transparency around costs and benefits.
  • Bug Fixes

    • Removed the setTokenPrice method from the payment interface to simplify component interactions.
  • Documentation

    • Updated rendering logic to conditionally display network costs and estimated points based on user selections.

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
peanut-ui ❌ Failed (Inspect) Sep 19, 2024 11:03am

Copy link
Contributor

coderabbitai bot commented Sep 18, 2024

Warning

Rate limit exceeded

@pawell24 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 49 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 0b1e7f8 and 088e9bd.

Walkthrough

Walkthrough

The changes involve modifications to the IPayScreenProps interface by removing the setTokenPrice method, indicating a redesign in how token price management is handled. Additionally, the PayRequestLink component has been enhanced with a new fetchPointsEstimation function that calculates estimated points based on transaction details. The Initial.view.tsx file has been updated to accept new props for displaying estimated points and USD amounts, improving user feedback regarding transaction costs and potential rewards.

Changes

Files Change Summary
src/components/Request/Pay/Pay.consts.ts Removed setTokenPrice: (value: number) => void from IPayScreenProps interface.
src/components/Request/Pay/Pay.tsx Added const { estimatePoints } and const fetchPointsEstimation(requestLinkDetails, tokenPrice) in PayRequestLink.
src/components/Request/Pay/Views/Initial.view.tsx Added estimatedPoints and amountUsd props to InitialView component for displaying transaction details.

Possibly related PRs

  • Fix fetching tx fee #379: The changes in Initial.view.tsx related to transaction fee estimation are relevant as they enhance the user experience and control flow, which may interact with the changes made in the main PR regarding token price management.
  • Fix input amount #380: The modifications in Initial.view.tsx for handling token values and formatting are related since they involve the same component and may affect how token amounts are processed in conjunction with the changes to the IPayScreenProps interface in the main PR.

Suggested reviewers

  • (No suggested reviewers provided)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@@ -19,6 +20,20 @@ export const PayRequestLink = () => {
const [estimatedGasCost, setEstimatedGasCost] = useState<number | undefined>(undefined)
const [transactionHash, setTransactionHash] = useState<string>('')
const [unsignedTx, setUnsignedTx] = useState<peanutInterfaces.IPeanutUnsignedTransaction | undefined>(undefined)
const { estimatePoints } = useClaimLink()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const { estimatePoints } = useClaimLink()
Is this good code practice? UseClaimLink in request link?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants