Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.13.0 #28

Open
wants to merge 97 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
97 commits
Select commit Hold shift + click to select a range
2fdf67c
Update ChangeLog and IngestLDD
matthewtiscareno Nov 18, 2024
3728882
Add logs from failed LDD generation
pdsen-ci Nov 18, 2024
c863380
Update IngestLDD
matthewtiscareno Nov 22, 2024
4cbacb2
Auto-generated LDDs by PDSEN CI Bot
pdsen-ci Nov 22, 2024
30a2969
Edits to change log
matthewtiscareno Nov 22, 2024
3c15571
Update IngestLDD and change log
matthewtiscareno Nov 27, 2024
4b845b8
Auto-generated LDDs by PDSEN CI Bot
pdsen-ci Nov 27, 2024
fa23806
Increment version number for attribute where we corrected a spelling …
matthewtiscareno Nov 27, 2024
03b5a69
Auto-generated LDDs by PDSEN CI Bot
pdsen-ci Nov 27, 2024
0466bc6
Update change log
matthewtiscareno Nov 27, 2024
4aa49e3
Fix uppercase X typo in test_no_maximum_wavelength_FAIL.xml
mace-space Dec 3, 2024
ce1a73c
Auto-generated LDDs by PDSEN CI Bot
pdsen-ci Dec 3, 2024
860862d
Update Occultation_Time_Series DD_Rule to remove Wavelength_Parameter…
mace-space Dec 3, 2024
009b95a
Merge branch 'release/1.13.0' of github.com:pds-data-dictionaries/ldd…
mace-space Dec 3, 2024
9d7e1de
Add logs from failed LDD generation
pdsen-ci Dec 3, 2024
16e9704
Having checked PDS4 LDD Automation logs after removing 'Wavelength_Pa…
mace-space Dec 3, 2024
f481e14
Merge branch 'release/1.13.0' of github.com:pds-data-dictionaries/ldd…
mace-space Dec 3, 2024
cfed2ed
Auto-generated LDDs by PDSEN CI Bot
pdsen-ci Dec 3, 2024
0f93fad
Adding tests for Occultation_Ring_Profile and Ring_Spectrum classes
esimpsons3ti Dec 4, 2024
c82f074
Updated Wavelength_Parameters DD Rules
esimpsons3ti Dec 9, 2024
965db59
Add logs from failed LDD generation
pdsen-ci Dec 9, 2024
5e2d3f1
Adding '_1' to Wavelength_Parameters local_identifier
esimpsons3ti Dec 9, 2024
435e391
Add logs from failed LDD generation
pdsen-ci Dec 9, 2024
3efed7e
Addressing errors from test logs
esimpsons3ti Dec 9, 2024
e0984d3
Add logs from failed LDD generation
pdsen-ci Dec 9, 2024
b627fe9
Placed rings:star_name after rings:occultation_direction
esimpsons3ti Dec 9, 2024
14d14f3
Add logs from failed LDD generation
pdsen-ci Dec 9, 2024
383e8b3
Changed location of rings:star_name
esimpsons3ti Dec 9, 2024
d955a68
Add logs from failed LDD generation
pdsen-ci Dec 9, 2024
d612dee
Changed rings:star_name from 'Sun' to 'sigma Sgr'
esimpsons3ti Dec 9, 2024
b48822b
Add logs from failed LDD generation
pdsen-ci Dec 9, 2024
4f27344
Fixed incorrect indentation for the Wavelength_Parameters DD_Rule
esimpsons3ti Dec 9, 2024
00f3ee9
Add logs from failed LDD generation
pdsen-ci Dec 9, 2024
00b56b9
Changed values of attributes to reflect data types
esimpsons3ti Dec 9, 2024
2e44fa1
Add logs from failed LDD generation
pdsen-ci Dec 9, 2024
ea3611f
Debugging by removing unrequired longitude and azimuth attributes
mace-space Dec 9, 2024
933ee2c
Add logs from failed LDD generation
pdsen-ci Dec 9, 2024
ba102da
Debug continued... removing ring_elevation attribute
mace-space Dec 9, 2024
a3f6b69
Merge branch 'release/1.13.0' of github.com:pds-data-dictionaries/ldd…
mace-space Dec 9, 2024
72bfa13
Add logs from failed LDD generation
pdsen-ci Dec 9, 2024
7c85c51
Debug continued... adding (required) longitude and azimuth attributes…
mace-space Dec 9, 2024
26a18b8
Add logs from failed LDD generation
pdsen-ci Dec 9, 2024
937edff
Debug continued... adding back in ring_elevation (required by DD_Rule)
mace-space Dec 9, 2024
ea13474
Add logs from failed LDD generation
pdsen-ci Dec 9, 2024
a8ddc2c
Reverting to Dec 4th IngestLDD
mace-space Dec 9, 2024
09fe0aa
Add logs from failed LDD generation
pdsen-ci Dec 9, 2024
5e7c0e2
Remove a test, as a test
matthewtiscareno Dec 9, 2024
4115afc
Add logs from failed LDD generation
pdsen-ci Dec 9, 2024
eb47af0
Continue test by removing tests
matthewtiscareno Dec 9, 2024
0d880d5
Auto-generated LDDs by PDSEN CI Bot
pdsen-ci Dec 9, 2024
760ca04
Changed value of information_model_version to 1.23.0, added first Rin…
esimpsons3ti Dec 12, 2024
33e7b9d
Auto-generated LDDs by PDSEN CI Bot
pdsen-ci Dec 12, 2024
c26b3d5
Adding the rest of the Ring_Spectrum regregression tests
esimpsons3ti Dec 12, 2024
61b0400
Auto-generated LDDs by PDSEN CI Bot
pdsen-ci Dec 12, 2024
d29df20
Adding first Occultation_Ring_Profile regression test
esimpsons3ti Dec 12, 2024
6de50ff
Removing hardcoded schema from Occultation_Ring_Profile test
esimpsons3ti Dec 12, 2024
b48d527
Add logs from failed LDD generation
pdsen-ci Dec 12, 2024
2ad3492
Made changes to LDD, schema to remove mention of deprecated ring_long…
esimpsons3ti Dec 18, 2024
f71dbf1
Add logs from failed LDD generation
pdsen-ci Dec 18, 2024
bc412e6
Removing stray rings_longitude instance
esimpsons3ti Dec 18, 2024
638874f
Add logs from failed LDD generation
pdsen-ci Dec 18, 2024
d536f46
Fixed missing corotating_ring_longitude definition in PDS4_RINGS_1M00…
esimpsons3ti Dec 18, 2024
4aa5297
Auto-generated LDDs by PDSEN CI Bot
pdsen-ci Dec 18, 2024
282c536
Removing hardcoded schema from test file, adding new test file
esimpsons3ti Dec 18, 2024
f2d969f
Auto-generated LDDs by PDSEN CI Bot
pdsen-ci Dec 18, 2024
9e2f55f
Adding the remaining tests for Occultation_Ring_Profile
esimpsons3ti Dec 18, 2024
8b65699
Add logs from failed LDD generation
pdsen-ci Dec 18, 2024
f611af6
Placing Wavelength_Parameters class in the correct spot
esimpsons3ti Dec 18, 2024
8975ac7
Auto-generated LDDs by PDSEN CI Bot
pdsen-ci Dec 18, 2024
676d95b
Cleanup longitude calls in classes
matthewtiscareno Dec 18, 2024
c415fca
Auto-generated LDDs by PDSEN CI Bot
pdsen-ci Dec 18, 2024
6a09e9b
Add Reprojection_Grid_Parameters class with its attributes
matthewtiscareno Dec 18, 2024
63fc9a3
Add logs from failed LDD generation
pdsen-ci Dec 18, 2024
97c4be5
Minor fix to previous commit
matthewtiscareno Dec 18, 2024
f53922b
Auto-generated LDDs by PDSEN CI Bot
pdsen-ci Dec 18, 2024
0245fff
More changes per Issue 301
matthewtiscareno Dec 18, 2024
e4c4a4b
Auto-generated LDDs by PDSEN CI Bot
pdsen-ci Dec 18, 2024
332416f
Update IngestLDD as recorded in ChangeLog
matthewtiscareno Jan 8, 2025
76dd736
Auto-generated LDDs by PDSEN CI Bot
pdsen-ci Jan 8, 2025
8ef963e
Fix typos in IngestLDD
matthewtiscareno Jan 15, 2025
3fc4d61
Auto-generated LDDs by PDSEN CI Bot
pdsen-ci Jan 15, 2025
f38297f
Add Column_Headers class, add rule_display_direction_check Schematron…
matthewtiscareno Jan 22, 2025
7bd676e
Add logs from failed LDD generation
pdsen-ci Jan 22, 2025
0db2254
Update IngestLDD headers
matthewtiscareno Jan 22, 2025
ef654d5
Add logs from failed LDD generation
pdsen-ci Jan 22, 2025
5794904
Add 1N to pds4_versions
matthewtiscareno Jan 22, 2025
628ad9b
Add logs from failed LDD generation
pdsen-ci Jan 22, 2025
8d79b78
Comment out the new Schematron rule
matthewtiscareno Jan 22, 2025
e71e2e9
Auto-generated LDDs by PDSEN CI Bot
pdsen-ci Jan 22, 2025
de580aa
Convert Wavelength_Parameters to Wavelength_Min_Max using XSChoice, a…
matthewtiscareno Jan 22, 2025
faf99b8
Add logs from failed LDD generation
pdsen-ci Jan 22, 2025
0f76b1e
Comment out the new Schematron rule
matthewtiscareno Jan 22, 2025
89af22c
Add logs from failed LDD generation
pdsen-ci Jan 22, 2025
022ca0d
Convert Wavelength_Parameters to Wavelength_Min_Max, as a test
matthewtiscareno Jan 22, 2025
ecd79ce
Add logs from failed LDD generation
pdsen-ci Jan 22, 2025
8d59734
Revert the Wavelength_Min_Max test
matthewtiscareno Jan 22, 2025
3fea1f2
Auto-generated LDDs by PDSEN CI Bot
pdsen-ci Jan 22, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
212 changes: 212 additions & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,212 @@
# Rings Namespace Change Log

## Changes from v1.12.0.0 to v1.13.0

### Switched to three-element semantic versioning
- For example, this is v1.13.0, not v1.13.0.0

### Migrated the change log from a comment in the IngestLDD to a file ChangeLog.md in the ldd-rings directory
- We used the change log in the Spectral LDD as a template

### Add Wavelength_Parameters class
- Added a new class, `Wavelength_Parameters`, which includes the three existing wavelength attributes: `wavelength`, `minimum_wavelength`, and `maximum_wavelength`
- Updated the classes that already use the wavelength attributes to use the new class, and incremented the version numbers for those classes (new version in parentheses): Occultation_Ring_Profile (2.0), Occultation_Time_Series (2.0), and Ring_Spectrum (2.0)
- Updated associated schematron rules
- Added associated unit tests
- Discussion found at https://github.com/pds-data-dictionaries/ldd-rings/pull/24

### Remove attributes that have been previously deprecated
- Namely `ring_longitude`, `minimum_ring_longitude`, and `maximum_ring_longitude`

### Issue #241: Reprojection grid attributes for ring coordinate system and Issue #301: Update Rings dictionary for R&A F ring mosaics project
- 1/22: WE DID SOME TESTS OF A WAVELENGTH_MIN_MAX CLASS, BUT CANNOT DO A XSCHOICE BETWEEN A CLASS AND AN ATTRIBUTE.
- SOME THINGS STILL TO DO
- We added the class `Reprojection_Grid_Parameters` containing new attributes `reprojection_grid_radial_resolution_mean`, `reprojection_grid_radial_resolution_min`, `reprojection_grid_radial_resolution_max`, `reprojection_grid_angular_resolution_mean`, `reprojection_grid_angular_resolution_min`, and `reprojection_grid_angular_resolution_max`. WE STILL NEED DEFINITIONS AND UNIT TESTS, AND THIS WILL BE SUBJECT TO THE REORGANIZATION MENTIONED BELOW.
- We made changes to the definitions of corotating_flag, emission_angle, and light_source_incidence_angle and corrected spelling errors in multiple attributes.
- INSTEAD OF SIMPLY ADDING MINIMUM_INCIDENCE_ANGLE AND MAXIMUM_INCIDENCE_ANGLE TO THE REPROJECTION_GEOMETRY CLASS, CONSIDER MORE BROADLY MAKING MANY OF THESE ATTRIBUTES A XS.CHOICE BETWEEN (FOR EXAMPLE) THE ATTRIBUTE INCIDENCE ANGLE AND A CLASS CALLED INCIDENCE_ANGLE_RANGE, THE LATTER HAS MINIMUM_INCIDENCE_ANGLE AND MAXIMUM_INCIDENCE_ANGLE REQUIRED.
- ROB'S POINTS ARE MOSTLY EDITS OF ATTRIBUTE DEFINITIONS
- ROB'S DISCUSSION OF INCIDENCE ANGLES AND RING LONGITUDES MAY ALSO FIT WITH THE IDEA ABOVE ABOUT DOING THESE WITH CLASSES
- Discussion found at https://github.com/pds-data-dictionaries/PDS4-LDD-Issue-Repo/issues/241 and https://github.com/pds-data-dictionaries/PDS4-LDD-Issue-Repo/issues/301
- Resolves pds-data-dictionaries/PDS4-LDD-Issue-Repo#241
- Resolves pds-data-dictionaries/PDS4-LDD-Issue-Repo#301

### Issue #243: Define Local_Internal_Reference in Ring_Reprojection
- Added schematron rule rule_display_direction_check, BUT IT DIDN'T WORK SO WE COMMENTED IT OUT.
- STILL TO DO: CREATE UNIT TESTS
- STILL TO DO: REMOVE DISPLAY_DIRECTION, ALL ITS CHILD ATTRIBUTES, AND THE REFERENCES TO IT
- Discussion found at https://github.com/pds-data-dictionaries/PDS4-LDD-Issue-Repo/issues/243
- Resolves pds-data-dictionaries/PDS4-LDD-Issue-Repo#243

### Issue #245: Update epoch_reprojection_basis_utc
- Added words for increased clarity to the definitions of the following attributes (new version in parentheses): epoch_reprojection_basis_utc (2.0, see below), corotating_ring_longitude (1.1), minimum_corotating_ring_longitude (1.1), and maximum_corotating_ring_longitude (1.1)
- Discussion found at https://github.com/pds-data-dictionaries/PDS4-LDD-Issue-Repo/issues/245
- Resolves pds-data-dictionaries/PDS4-LDD-Issue-Repo#245

### Issue #267: Create class for attributes that are not currently members of any class
- Created the class Column_Headers
- STILL TO DO: COLLECT ALL ATTRIBUTES THAT SHOULD LIVE WITHIN THIS CLASS
- Discussion found at https://github.com/pds-data-dictionaries/PDS4-LDD-Issue-Repo/issues/267
- Resolves pds-data-dictionaries/PDS4-LDD-Issue-Repo#267

### Issue #302: Fix various copy-editing errors in the Rings dictionary
- STILL TO FINISH
- Discussion found at https://github.com/pds-data-dictionaries/PDS4-LDD-Issue-Repo/issues/302
- Resolves pds-data-dictionaries/PDS4-LDD-Issue-Repo#302

### Issue #306: Fix data type and unit issues for UTC attributes
- Removed specification of "Units_of_Time" for attributes that have data type ASCII_Date_Time_YMD_UTC, where it had been mistakenly included, for the following attributes (new version in parentheses): reference_time_utc (2.0), spacecraft_event_start_time_utc (2.0), spacecraft_event_stop_time_utc (2.0), earth_received_start_time_utc (2.0), earth_received_stop_time_utc (2.0), ring_event_start_time_utc (2.0), ring_event_stop_time_utc (2.0), epoch_ring_fit_utc (2.0), epoch_reprojection_basis_utc (2.0)
- For the attribute observed_event_time_utc, change data type from ASCII_Real (which was mistaken) to ASCII_Date_Time_YMD_UTC. Consequently, remove "Units_of_Time" here also. Incremented the version to 2.0 for this attribute.
- Discussion found at https://github.com/pds-data-dictionaries/PDS4-LDD-Issue-Repo/issues/306
- Resolves pds-data-dictionaries/PDS4-LDD-Issue-Repo#306

### General Cleanup
- Fixed spelling error in `ring_longitude_observed_minus_subsolar` definition: "providees" ==> "provides". Incremented the version to 1.1 for this attribute.

## Changes between v1.0 and v1.12.0.0

### v1.12.0.0 2023-04-18
- Update steward name from Mitchell Gordon to Matthew Tiscareno
- Improved definitions of epoch_reprojection_basis_utc, corotating_ring_longitude, minimum_corotating_ring_longitude,
and maximum_corotating_ring_longitude.
- Fixed typo in corotating_flag enumerated value definition.
- Regularized spelling of "corotation"
- Add inertial_ring_longitude, minimum_inertial_ring_longitude, and maximum_inertial_ring_longitude. These replace
ring_longitude, minimum_ring_longitude, and maximum_ring_longitude, which should be deprecated.
- Also, classes that are copied here from the Geometry and Display dictionaries should be deprecated, as of now.
These include Body_Ident_Base, Reference_Frame_Ident, Central_Body_Ident, and Display_Direction.
- Actual deprecation not yet implemented.

### v1.11.0.0 2021-11-10
- Defined the attributes and included in Occultation_Time_Series:
minimum_projected_sun_diameter, maximum_projected_sun_diameter,
sigma_projected_sun_diameter, average_unocculted_signal,
lowest_detectable_normal_optical_depth, highest_detectable_normal_optical_depth,
- Defined attributes antipated to be used as columns in data tables:
observed_event_TDB_start_integration, observed_event_TDB_mid_integration,
observed_event_TDB_stop_integration, ring_event_TDB_start_integration,
ring_event_TDB_mid_integration, ring_event_TDB_stop_integration,
ring_radius_start_integration, ring_radius_mid_integration, ring_radius_stop_integration,
raw_total_counts,counts_per_second, transparency, normal_optical_depth,
projected_sun_diameter.
- In Occultation_Ring_Profile and Occultation_Time_Series,changed the cardinality of
data_quality_index to [0,*].
- Added to data_quality_index enumerated values to support solar occultations: B, F, R, U, X.
- Revised the case of several attribute enumerated values to Title case.
- Added the attribute: ring_detected.
- Added attributes min/max ring_longitude and observed_ring azimuth to Occultation_Time_Series

### v1.10.0.0 2020-06-25
- Updated to version 1.14.0.0 of IM.
- Added the attributes: data_quality_index, ring_detected.
- Revised the case of several attribute enumerated values from Title case to all lower case. The named rings of
Saturn are in title case while those of Uranus are lower case, consistent with normal usage by the community.
- Added attributes min/max ring_longitude and observed_ring azimuth to Occultation_Time_Series.
- Expanded definitions of highest and lowest detectable opacity. In each, set the minimum value to -1.0 which
indicates the signal was too poor to allow the calculation of the value.

### v1.9.0.0 2020-01-31
- Updated to version 1.13.0.0 of IM.
- Add Units of Measure Type = Gmass to the gmass attribute.

### v1.8.0.0 2020-01-28
- Updated to version 1.12.0.0 of IM.
- Made Ring_Moon_Systems class the only xsi element.
- removed the attribute source_pds3_id and spice_filename
- removed milable from orbit_number and along_track_timing.
- Added attributes fresnel_scale, projected_star_diameter, sigma_projected_star_diameter, fractional_error_star_counts,
time_constant_type, time_constant, sigma_time_constant.
- All 7 of the preceding were added as optional attributes in the Occultation_Time_Series class

### v1.7.0.0 2019-03-07
- Updated to version 1.10.0.0 of IM.
- Removed the Rings_Supplement class.
- Removed the ring_observation_id attribute.
- Removed pds:Internal_Reference from the Body_Ident_Base and Frame_Ident_Base classes.
- Added a SChematron definition for a value in reference_type in pds:Internal_Reference in Uniformly_Sampled_Radius

### v1.6.0.0 2019-03-06
- Updated to version 1.9.0.0 of IM.
- Added the Ring_Model class and numerous classes and attributes to support it.
- Added the Orbital_Elements class.
- ring_event_tdb - changed the enumeration flag to false
- added optional description attribute to several classes
- added classes to support ring mosaics: Ring_Reprojection and Reprojection_Geometry.
- added several attributes to support ring mosaics.
- Added Display_Direction including pds:local_identifier_reference with a cardinality of [0,*].
- Added the class Ring_Spectrum
- Added attributes
- emission angle
- ring_intercept_resolution
- ring_longitude_observed_minus_subsolar
- reflectivity
- Added an optional pds.local_identifier attribute to most classes.
- As an interim bandaid(?) pending repair of LDDTool, added several classes
and attributes 'borrowed' from the geometry dictionary and removed the
geom. prefixes to those classes in this dictionary. The affected classes
are:
- Body_Ident_Base
- Frame_Ident_Base (not used explicitly when geom is referenced)
- Reference_Frame_Ident
- Central_Body_Ident
- Added Uniformly_Sampled_Radius based on Uniformly_Sampled_Wavelength from the sp namespace
- Made the use of ring_observation_id optional.
- @@@ Need schematron rule to ensure values for axis_name correspond to entries in Axis_Array.name

### v1.5.1.0 2017-08-09
- corrected minor formating errors for a few enumerated values
- Reinstated the ring_plane attribute in the Occultation_Ring_Profile and Occultation_Time_Series classes.

### v1.5.0.0 2017-04-12
- Changed schema location URLs to https
- Updated to version 1.8.0.0 of IM.
- Revised definition of pds3_source_id
- Corrected the definition of sub_stellar_ring_azimuth
- Changed the name of the umbrella class from Occultation to Ring_Moon_Systems
- Added Time_Series_Direction

### v1.4.0.0 2016-04-25
- This version was not released
- Updated to version 1.6.0.0 of IM.
- Corrected case errors in class and attribute names and enumerated values
- Changed several time attribute types from ASCII_Date_Time_UTC to ASCII_Date_Time_YMD_UTC
- revised several definitions
- Changed ring_occultation_direction to occultation_direction, and modified the definitions
for the values ingress and egress.
- Added the class Occultation_Time_Series.
- Combined Radio_Occultation and Stellar_Occultation into Occultation_Ring_Profile
- Renamed Radio_Occultation_Support to Occultation_Supplement
- Removed ring_observation_id and source_pds3_id from all classes except Occultation_Supplement.
- Added Schematron rules to make some optional attributes required based on the value of
occultation type (e.g., dsn_station_number if occultation_type = radio, sub_stellar_ring_azimuth
if occultation_type = stellar).
- Reordered some attributes in Occultation_Time_Series.
- Reordered some attributes in Occultation_Supplement.

### v1.3.0 2015-01-23
- Updated to version 1.3.0.1 of IM.
- Added min/max_observed_event_time.
- Included reference_time_UTC as optional attribute for all profile labels.
- Revised some definitions.

### v1.2.0 2014-03-29
- Moved information from comments into definitions for all attributes.
- Added source product, orbit number and sclk start/stop times.
- Revised some enumerated value options, and corrected some nillable inconsistencies.

### Classes used from the geom namespace
- Body_Ident_Base
- Reference_Frame_Ident
- Central_Body_Ident
- Display_Direction

### Classes used from the pds namespace
- Internal_Reference

### Attributes used from the pds namespace
- local_identifier_reference
- sampling_parameter_name
- sampling_parameter_unit
- sampling_parameter_interval
- description
- name (indirectly via classes from the geom namespace)
- comment (indirectly via classes from the geom namespace)

This file was deleted.

Loading