Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.13.0 #28

Open
wants to merge 97 commits into
base: main
Choose a base branch
from
Open

Release/1.13.0 #28

wants to merge 97 commits into from

Conversation

matthewtiscareno
Copy link
Contributor

@matthewtiscareno matthewtiscareno commented Nov 22, 2024

Summary

Switched to three-element semantic versioning

  • For example, this is v1.13.0, not v1.13.0.0

Migrated the change log from a comment in the IngestLDD to a file ChangeLog.md in the ldd-rings directory

  • We used the change log in the Spectral LDD as a template

Add Wavelength_Parameters class

  • Added a new class, Wavelength_Parameters, which includes the three existing wavelength attributes: wavelength, minimum_wavelength, and maximum_wavelength
  • Updated the classes that already use the wavelength attributes to use the new class, and incremented the version numbers for those classes (new version in parentheses): Occultation_Ring_Profile (2.0), Occultation_Time_Series (2.0), and Ring_Spectrum (2.0)
  • Updated associated schematron rules
  • Added associated unit tests
  • Discussion found at V1.13.0 #24

Remove attributes that have been previously deprecated

  • Namely ring_longitude, minimum_ring_longitude, and maximum_ring_longitude

Issue #241: Reprojection grid attributes for ring coordinate system and Issue #301: Update Rings dictionary for R&A F ring mosaics project

Issue #243: Define Local_Internal_Reference in Ring_Reprojection

Issue #245: Update epoch_reprojection_basis_utc

Issue #267: Create class for attributes that are not currently members of any class

Issue #302: Fix various copy-editing errors in the Rings dictionary

Issue #306: Fix data type and unit issues for UTC attributes

  • Removed specification of "Units_of_Time" for attributes that have data type ASCII_Date_Time_YMD_UTC, where it had been mistakenly included, for the following attributes (new version in parentheses): reference_time_utc (2.0), spacecraft_event_start_time_utc (2.0), spacecraft_event_stop_time_utc (2.0), earth_received_start_time_utc (2.0), earth_received_stop_time_utc (2.0), ring_event_start_time_utc (2.0), ring_event_stop_time_utc (2.0), epoch_ring_fit_utc (2.0), epoch_reprojection_basis_utc (2.0)
  • For the attribute observed_event_time_utc, change data type from ASCII_Real (which was mistaken) to ASCII_Date_Time_YMD_UTC. Consequently, remove "Units_of_Time" here also. Incremented the version to 2.0 for this attribute.
  • Discussion found at [ldd-rings] Fix data type and unit issues for UTC attributes PDS4-LDD-Issue-Repo#306
  • Resolves [ldd-rings] Fix data type and unit issues for UTC attributes PDS4-LDD-Issue-Repo#306

General Cleanup

  • Fixed spelling error in ring_longitude_observed_minus_subsolar definition: "providees" ==> "provides". Incremented the version to 1.1 for this attribute.

Test Data and/or Report

Enter info here

Related Issues

Enter related issues here

@matthewtiscareno matthewtiscareno requested a review from a team as a code owner November 22, 2024 00:39
matthewtiscareno and others added 25 commits November 21, 2024 16:42
…rameters/' from the Occultation_Time_Series DD_Rule xpath (currently only time series tests written), reverting back to including the 'Wavelength_Parameters/' since existing VALID tests failed
esimpsons3ti and others added 30 commits December 18, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment