-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/1.13.0 #28
Open
matthewtiscareno
wants to merge
97
commits into
main
Choose a base branch
from
release/1.13.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release/1.13.0 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error in the description
…s xpath to check if tests still work
…-rings into release/1.13.0
…rameters/' from the Occultation_Time_Series DD_Rule xpath (currently only time series tests written), reverting back to including the 'Wavelength_Parameters/' since existing VALID tests failed
…-rings into release/1.13.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Switched to three-element semantic versioning
Migrated the change log from a comment in the IngestLDD to a file ChangeLog.md in the ldd-rings directory
Add Wavelength_Parameters class
Wavelength_Parameters
, which includes the three existing wavelength attributes:wavelength
,minimum_wavelength
, andmaximum_wavelength
Remove attributes that have been previously deprecated
ring_longitude
,minimum_ring_longitude
, andmaximum_ring_longitude
Issue #241: Reprojection grid attributes for ring coordinate system and Issue #301: Update Rings dictionary for R&A F ring mosaics project
Reprojection_Grid_Parameters
containing new attributesreprojection_grid_radial_resolution_mean
,reprojection_grid_radial_resolution_min
,reprojection_grid_radial_resolution_max
,reprojection_grid_angular_resolution_mean
,reprojection_grid_angular_resolution_min
, andreprojection_grid_angular_resolution_max
. WE STILL NEED DEFINITIONS AND UNIT TESTS, AND THIS WILL BE SUBJECT TO THE REORGANIZATION MENTIONED BELOW.Issue #243: Define Local_Internal_Reference in Ring_Reprojection
Issue #245: Update epoch_reprojection_basis_utc
Issue #267: Create class for attributes that are not currently members of any class
Issue #302: Fix various copy-editing errors in the Rings dictionary
Issue #306: Fix data type and unit issues for UTC attributes
General Cleanup
ring_longitude_observed_minus_subsolar
definition: "providees" ==> "provides". Incremented the version to 1.1 for this attribute.Test Data and/or Report
Enter info here
Related Issues
Enter related issues here