Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: empty venv instead of remove it #2282

Merged
merged 2 commits into from
Oct 6, 2023
Merged

fix: empty venv instead of remove it #2282

merged 2 commits into from
Oct 6, 2023

Conversation

dennispg
Copy link
Contributor

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

fix for #2270

frostming
frostming requested changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@frostming frostming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a news fragment and we are good to go.

@codecov
Copy link

codecov bot commented Sep 29, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/pdm/cli/commands/venv/backends.py 85.84% <50.00%> (-2.84%) ⬇️

📢 Thoughts on this report? Let us know!.

@dennispg
Copy link
Contributor Author

done! thanks!

@frostming frostming merged commit 9e6b9a2 into pdm-project:main Oct 6, 2023
@j178 j178 mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frostming frostming frostming requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dennispg @frostming