VirtualenvCreateError: checking for .venv existence rather than emptiness

[dennispg]

• I have searched the issue tracker and believe that this is not a duplicate.

Make sure you run commands with -v flag before pasting the output.

Steps to reproduce

I am mounting a docker volume in my devcontainer at <project path>/.venv to try and cache the virtual environments between rebuilds, and then running pdm venv create in my project. I also have venv.in_project set to true in pdm.toml.

Actual behavior

[VirtualenvCreateError]: The location /<project path>/.venv is not empty, add --force to overwrite it.

Adding --force gives:

Cleaning existing target directory /<project path>/.venv
[OSError]: [Errno 16] Device or resource busy: '/<project path>/.venv'
Add '-v' to see the detailed traceback

Expected behavior

The .venv volume is in fact empty, however pdm is looking for existence rather than empty and since the volume mount cannot be deleted, it fails.

Can _ensure_clean instead check that the directory is empty and be done with it?

https://github.com/pdm-project/pdm/blob/main/src/pdm/cli/commands/venv/backends.py#L81

Adding this seems to resolve it for me:

        if location.is_dir() and not any(location.iterdir()):
            return

I can make a pull request to that effect if its deemed appropriate?

Environment Information

PDM version:
  2.9.2
{
  "implementation_name": "cpython",
  "implementation_version": "3.11.5",
  "os_name": "posix",
  "platform_machine": "aarch64",
  "platform_release": "6.4.16-orbstack-00103-g02b40eb69695",
  "platform_system": "Linux",
  "platform_version": "#1 SMP Wed Sep 13 10:13:30 UTC 2023",
  "python_full_version": "3.11.5",
  "platform_python_implementation": "CPython",
  "python_version": "3.11",
  "sys_platform": "linux"
}

[dennispg]

Here's my full patch:

3a4
> import os
73a75,76
>         if location.is_dir() and not any(location.iterdir()):
>             return
81c84,90
<             shutil.rmtree(location)
---
>             self.project.core.ui.echo("Dennis code here")
>             with os.scandir(location) as entries:
>                 for entry in entries:
>                     if entry.is_dir() and not entry.is_symlink():
>                         shutil.rmtree(entry.path)
>                     else:
>                         os.remove(entry.path)