Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecation warning when passing parser to Command.__init__ #2010

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

frostming
Copy link
Collaborator

Fixes #2009

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2023

Codecov Report

Patch coverage: 57.14% and project coverage change: -0.03 ⚠️

Comparison is base (ebfb98c) 85.21% compared to head (fb71679) 85.19%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2010      +/-   ##
==========================================
- Coverage   85.21%   85.19%   -0.03%     
==========================================
  Files          99       99              
  Lines        9370     9375       +5     
  Branches     2045     2046       +1     
==========================================
+ Hits         7985     7987       +2     
- Misses        940      942       +2     
- Partials      445      446       +1     
Flag Coverage Δ
unittests 84.99% <57.14%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/cli/commands/base.py 92.10% <57.14%> (-7.90%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit ce2f939 into main Jun 13, 2023
@frostming frostming deleted the frostming/issue2009 branch June 13, 2023 03:40
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected breaking change in BaseCommand when updating Patch-Version
2 participants