Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected breaking change in BaseCommand when updating Patch-Version #2009

Closed
1 task done
carstencodes opened this issue Jun 12, 2023 · 1 comment · Fixed by #2010
Closed
1 task done

Unexpected breaking change in BaseCommand when updating Patch-Version #2009

carstencodes opened this issue Jun 12, 2023 · 1 comment · Fixed by #2010
Assignees
@frostming
Labels
🐛 bug Something isn't working

Comments

@carstencodes
Copy link

  • I have searched the issue tracker and believe that this is not a duplicate.

Steps to reproduce

Update your PDM installation from PDM 2.7.1 to 2.7.2 and run a plug-in, e.g. pdm-bump

Actual behavior

Failed to load plugin pdm-bump=pdm_bump:main: BumpCommand.__init__() missing 1 required positional argument: 'parser'
Usage: pdm [-h] [-V] [-c CONFIG] [-v] [-I] [--pep582 [SHELL]] __root__ ...
pdm: error: unrecognized arguments: dev

src: https://github.com/carstencodes/pdm-bump/actions/runs/5246929518/jobs/9478135588#step:12:34

Expected behavior

The plug-in can be started without errors

Environment Information

## Not part of the CLI output.

Problematic change: f08b414 in #1983
@carstencodes carstencodes added the 🐛 bug Something isn't working label Jun 12, 2023
@carstencodes carstencodes mentioned this issue Jun 12, 2023
Closed
@frostming frostming self-assigned this Jun 13, 2023
frostming added a commit that referenced this issue Jun 13, 2023
@frostming
fix: deprecation warning when passing parser to Command.__init__
fb71679 
Fixes #2009

Signed-off-by: Frost Ming <[email protected]>
@frostming frostming mentioned this issue Jun 13, 2023
Merged
2 tasks
@frostming
Copy link
Collaborator

Thanks, will release the fix soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frostming frostming

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: deprecation warning when passing parser to Command.__init__ pdm-project/pdm
2 participants
@carstencodes @frostming